From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:40839 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756331AbcDHBKw (ORCPT ); Thu, 7 Apr 2016 21:10:52 -0400 Subject: Re: [PATCH v5 2/2] ARM: dts: imx: ventana: Add wdt ext-reset support To: Tim Harvey , linux-watchdog@vger.kernel.org, Shawn Guo References: <1459523804-11390-1-git-send-email-tharvey@gateworks.com> <1459523804-11390-3-git-send-email-tharvey@gateworks.com> Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Lucas Stach , Akshay Bhat , Wim Van Sebroeck , Stefan Roese , Iain Paton , Sascha Hauer From: Guenter Roeck Message-ID: <5707051D.4000806@roeck-us.net> Date: Thu, 7 Apr 2016 18:10:53 -0700 MIME-Version: 1.0 In-Reply-To: <1459523804-11390-3-git-send-email-tharvey@gateworks.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 04/01/2016 08:16 AM, Tim Harvey wrote: > The Gateworks Ventana boards have a PMIC that can be used to regulate the > CPU voltage rails for DVFS support. In order to ensure this PMIC is properly > reset the watchdog needs to be configured to assert its external reset > signal. > > Cc: Fabio Estevam > Cc: Lucas Stach > Cc: Stefan Roese > Cc: Iain Paton > Cc: Sascha Hauer > Cc: Akshay Bhat > Cc: Guenter Roeck > Signed-off-by: Tim Harvey Acked-by: Guenter Roeck > ---- > v5: > - changed property to 'fsl,ext-reset-output' > v4: > - put property in wdoggrp > > Signed-off-by: Tim Harvey > --- > arch/arm/boot/dts/imx6qdl-gw51xx.dtsi | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 17 +++++++++++++++++ > arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 12 ++++++++++++ > 6 files changed, 77 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > index 9d7ab6c..1340e27 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > @@ -228,6 +228,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw51xx { > pinctrl_enet: enetgrp { > @@ -364,5 +370,11 @@ > MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x1b0b0 /* OTG_PWR_EN */ > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > index 8dd74e9..8cccc4a 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > @@ -353,6 +353,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw52xx { > pinctrl_audmux: audmuxgrp { > @@ -549,5 +555,11 @@ > MX6QDL_PAD_NANDF_CS1__SD3_VSELECT 0x170f9 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > index ec3fe74..5f700cc 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > @@ -351,6 +351,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw53xx { > pinctrl_audmux: audmuxgrp { > @@ -539,5 +545,11 @@ > MX6QDL_PAD_NANDF_CS1__SD3_VSELECT 0x170f9 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > index 367cc49..d19b4cc 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > @@ -453,6 +453,17 @@ > status = "okay"; > }; > > +&wdog1 { > + status = "disabled"; > +}; > + > +&wdog2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > + status = "okay"; > +}; > + > &iomuxc { > imx6qdl-gw54xx { > pinctrl_audmux: audmuxgrp { > @@ -654,5 +665,11 @@ > MX6QDL_PAD_NANDF_CS1__SD3_VSELECT 0x170f9 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_SD1_DAT3__WDOG2_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > index 118bea5..4b9fef8 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > @@ -239,6 +239,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw51xx { > pinctrl_flexcan1: flexcan1grp { > @@ -333,5 +339,11 @@ > MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > index f27f184..805e236 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > @@ -197,6 +197,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw552x { > pinctrl_gpio_leds: gpioledsgrp { > @@ -286,5 +292,11 @@ > MX6QDL_PAD_KEY_ROW1__UART5_RX_DATA 0x1b0b1 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Thu, 7 Apr 2016 18:10:53 -0700 Subject: [PATCH v5 2/2] ARM: dts: imx: ventana: Add wdt ext-reset support In-Reply-To: <1459523804-11390-3-git-send-email-tharvey@gateworks.com> References: <1459523804-11390-1-git-send-email-tharvey@gateworks.com> <1459523804-11390-3-git-send-email-tharvey@gateworks.com> Message-ID: <5707051D.4000806@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/01/2016 08:16 AM, Tim Harvey wrote: > The Gateworks Ventana boards have a PMIC that can be used to regulate the > CPU voltage rails for DVFS support. In order to ensure this PMIC is properly > reset the watchdog needs to be configured to assert its external reset > signal. > > Cc: Fabio Estevam > Cc: Lucas Stach > Cc: Stefan Roese > Cc: Iain Paton > Cc: Sascha Hauer > Cc: Akshay Bhat > Cc: Guenter Roeck > Signed-off-by: Tim Harvey Acked-by: Guenter Roeck > ---- > v5: > - changed property to 'fsl,ext-reset-output' > v4: > - put property in wdoggrp > > Signed-off-by: Tim Harvey > --- > arch/arm/boot/dts/imx6qdl-gw51xx.dtsi | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 17 +++++++++++++++++ > arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 12 ++++++++++++ > arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 12 ++++++++++++ > 6 files changed, 77 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > index 9d7ab6c..1340e27 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > @@ -228,6 +228,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw51xx { > pinctrl_enet: enetgrp { > @@ -364,5 +370,11 @@ > MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x1b0b0 /* OTG_PWR_EN */ > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > index 8dd74e9..8cccc4a 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > @@ -353,6 +353,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw52xx { > pinctrl_audmux: audmuxgrp { > @@ -549,5 +555,11 @@ > MX6QDL_PAD_NANDF_CS1__SD3_VSELECT 0x170f9 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > index ec3fe74..5f700cc 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > @@ -351,6 +351,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw53xx { > pinctrl_audmux: audmuxgrp { > @@ -539,5 +545,11 @@ > MX6QDL_PAD_NANDF_CS1__SD3_VSELECT 0x170f9 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > index 367cc49..d19b4cc 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > @@ -453,6 +453,17 @@ > status = "okay"; > }; > > +&wdog1 { > + status = "disabled"; > +}; > + > +&wdog2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > + status = "okay"; > +}; > + > &iomuxc { > imx6qdl-gw54xx { > pinctrl_audmux: audmuxgrp { > @@ -654,5 +665,11 @@ > MX6QDL_PAD_NANDF_CS1__SD3_VSELECT 0x170f9 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_SD1_DAT3__WDOG2_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > index 118bea5..4b9fef8 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > @@ -239,6 +239,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw51xx { > pinctrl_flexcan1: flexcan1grp { > @@ -333,5 +339,11 @@ > MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > index f27f184..805e236 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > @@ -197,6 +197,12 @@ > status = "okay"; > }; > > +&wdog1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wdog>; > + fsl,ext-reset-output; > +}; > + > &iomuxc { > imx6qdl-gw552x { > pinctrl_gpio_leds: gpioledsgrp { > @@ -286,5 +292,11 @@ > MX6QDL_PAD_KEY_ROW1__UART5_RX_DATA 0x1b0b1 > >; > }; > + > + pinctrl_wdog: wdoggrp { > + fsl,pins = < > + MX6QDL_PAD_DISP0_DAT8__WDOG1_B 0x1b0b0 > + >; > + }; > }; > }; >