From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [PATCH] phy: rockchip-emmc: fix compile issue on arm64 platform Date: Fri, 8 Apr 2016 09:14:38 +0800 Message-ID: <570705FE.2000202@rock-chips.com> References: <1457425453-1996-1-git-send-email-shawn.lin@rock-chips.com> <570659EA.9000706@ti.com> <57066137.4040807@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <57066137.4040807-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Kishon Vijay Abraham I Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner List-Id: linux-rockchip.vger.kernel.org 5ZyoIDIwMTYvNC83IDIxOjMxLCBLaXNob24gVmlqYXkgQWJyYWhhbSBJIOWGmemBkzoKPiBIaSwK Pgo+IE9uIFRodXJzZGF5IDA3IEFwcmlsIDIwMTYgMDY6MzAgUE0sIEtpc2hvbiBWaWpheSBBYnJh aGFtIEkgd3JvdGU6Cj4+IEhpLAo+Pgo+PiBPbiBUdWVzZGF5IDA4IE1hcmNoIDIwMTYgMDE6NTQg UE0sIFNoYXduIExpbiB3cm90ZToKPj4+IFRoaXMgcGF0Y2ggcmVuYW1lICJyZWciIHByb3BlcnR5 IHRvICJyZWdfb2Zmc2V0Ii4KPj4+IFdlIHJlbmFtZSBpdCB0byBmaXggdGhlIGNvbXBpbGUgaXNz dWUgb24gQVJNNjQgcGxhdGZvcm06Cj4+PiAocmVnX2Zvcm1hdCk6ICJyZWciIHByb3BlcnR5IGlu IC9waHkgaGFzIGludmFsaWQgbGVuZ3RoICg0IGJ5dGVzKQo+Pj4gKCNhZGRyZXNzLWNlbGxzID09 IDIsICNzaXplLWNlbGxzID09IDIpCj4+Cj4+IElzIHRoZSBzYW1lIG5vZGUgdXNlZCBmb3IgYm90 aCBBUk0zMiBhbmQgQVJNNjQgcGxhdGZvcm1zPwo+Pgo+PiBUaGFua3MKPj4gS2lzaG9uCj4+Pgo+ Pj4gVGhpcydzIGJlY2F1c2UgInJlZyIgaXMgdmVyeSBzcGVjaWFsIG9uZSB3aGljaCBzaG91bGQg a2VlcCB0aGUKPj4+ICotY2VsbHMgd2l0aCBpdHMgcGFyZW50IG5vZGUgYW5kIGNhbid0IGJlIG92 ZXJ3cml0ZWQgZXZlbiBpZiB3ZQo+Pj4gZG8gdGhhdCBleHBsaWNpdGx5LiBPbiAzMi1iaXQgcGxh ZmZvcm0sIHRoZSBkZWZhdWx0ICotY2VsbHMKPj4+IGZpdCBmb3Igd2hhdCB3ZSBhc3NpZ24gdG8g InJlZyIuIEJ1dCB0aGF0J3Mgbm90IGNvcnJlY3QgZm9yIDY0LWJpdAo+Pj4gcGxhdGZvcm0uIFNv IHdlIGNhbiBzZWUgdHdvIHBvc3NpYmxlIHNvbHV0aW9ucyB0byBmaXggdGhpcyBwcm9ibGVtOgo+ Pj4gQSkgbWFrZSBwaHktcm9ja2NoaXAtZW1tYyBhcyBhIGNoaWxkIHBoeSBub2RlIGFuZCBvdmVy d3JpdGUgaXRzCj4+PiBwYXJlbnQncyAjYWRkcmVzcy1jZWxscyBhbmQgI3NpemUtY2VsbHMuCj4+ PiBCKSBhdm9pZCB1c2luZyB0aGlzIHNwZWNpYWwgcHJvcGVydHkuCj4+Pgo+Pj4gd2UgdXNlIGl0 IGp1c3QgZm9yIHBhc3Npbmcgb24gYSBvZmZzZXQgZm9yIGRpZmZlcmVudCBTb2NzLCBhbmQgdGhl cmUncwo+Pj4gbm8gcmVxdWlyZW1lbnQgdG8gY2hhbmdlIHRoZSBjb2RlIHRvIG1ha2UgcGh5LXJv Y2tjaGlwLWVtbWMgYXMgYSBjaGlsZAo+Pj4gbm9kZS4gc28gY2hvb3NlIG9wdGlvbiBCKSBpcyBz YW5lLgo+Cj4gSSBqdXN0IGxvb2tlZCBhdCB0aGUgSGVpa28ncyBwYXRjaCBhbmQgaXQgbWFrZXMg bW9yZSBzZW5zZSB0byBoYXZlIHRoZSBiaW5kaW5nCj4gdGhhdCBoZSBkZXNjcmliZWQgaW4gaGlz IHBhdGNoIFsxXS4gQ2FuIHlvdSBmaXggaXQgYWNjb3JkaW5nbHk/Cgp5ZXMsIEhlaWtvJ3MgcGF0 Y2ggaXMgbW9yZSByZWFzb25hYmxlIHRvIG1lLiBXaXRoIGhpcyBwYXRjaCBhcHBsaWVkLAp0aGlz IGlzc3VlIGlzIGdvbmUgaWYgYXNzaWduaW5nIGFkZHJlc3MtY2VsbHMgaW4gZHQgZm9yIGdyZi4K ClNvIHdlIGNhbiBkcm9wIHRoaXMgcGF0Y2guCgo+Cj4gSSBzZWVtIHRvIGhhdmUgb25seSB0aGlz IHBhdGNoIGFuZCBIZWlrbydzIHBhdGNoIGZvciB0aGlzIC1yYyBjeWNsZS4gT25jZSB5b3UKPiBz ZW5kIHlvdXIgcGF0Y2gsIEkgY2FuIHNlbmQgYSBwdWxsIHJlcXVlc3QgdG8gR3JlZy4KPgo+IFRo YW5rcwo+IEtpc2hvbgo+Cj4gWzFdLSA+IGh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0 Y2gvNjAxNTgwLwo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFNoYXduIExpbiA8c2hhd24ubGluQHJv Y2stY2hpcHMuY29tPgo+Pj4gLS0tCj4+Pgo+Pj4gICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvcGh5L3JvY2tjaGlwLWVtbWMtcGh5LnR4dCB8IDQgKystLQo+Pj4gICBkcml2ZXJz L3BoeS9waHktcm9ja2NoaXAtZW1tYy5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDIg Ky0KPj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p Cj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9w aHkvcm9ja2NoaXAtZW1tYy1waHkudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3BoeS9yb2NrY2hpcC1lbW1jLXBoeS50eHQKPj4+IGluZGV4IDYxOTE2ZjEuLmVkOTY0ZWYg MTAwNjQ0Cj4+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3Jv Y2tjaGlwLWVtbWMtcGh5LnR4dAo+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3BoeS9yb2NrY2hpcC1lbW1jLXBoeS50eHQKPj4+IEBAIC02LDcgKzYsNyBAQCBSZXF1 aXJlZCBwcm9wZXJ0aWVzOgo+Pj4gICAgLSByb2NrY2hpcCxncmYgOiBwaGFuZGxlIHRvIHRoZSBz eXNjb24gbWFuYWdpbmcgdGhlICJnZW5lcmFsCj4+PiAgICAgIHJlZ2lzdGVyIGZpbGVzIgo+Pj4g ICAgLSAjcGh5LWNlbGxzOiBtdXN0IGJlIDAKPj4+IC0gLSByZWc6IFBIWSBjb25maWd1cmUgcmVn IGFkZHJlc3Mgb2Zmc2V0IGluICJnZW5lcmFsCj4+PiArIC0gcmVnX29mZnNldDogUEhZIGNvbmZp Z3VyZSByZWcgYWRkcmVzcyBvZmZzZXQgaW4gImdlbmVyYWwKPj4+ICAgICAgcmVnaXN0ZXIgZmls ZXMiCj4+Pgo+Pj4gICBFeGFtcGxlOgo+Pj4gQEAgLTE0LDYgKzE0LDYgQEAgRXhhbXBsZToKPj4+ ICAgZW1tY3BoeTogcGh5IHsKPj4+ICAgCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LWVt bWMtcGh5IjsKPj4+ICAgCXJvY2tjaGlwLGdyZiA9IDwmZ3JmPjsKPj4+IC0JcmVnID0gPDB4Zjc4 MD47Cj4+PiArCXJlZ19vZmZzZXQgPSA8MHhmNzgwPjsKPj4+ICAgCSNwaHktY2VsbHMgPSA8MD47 Cj4+PiAgIH07Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcGh5LXJvY2tjaGlwLWVtbWMu YyBiL2RyaXZlcnMvcGh5L3BoeS1yb2NrY2hpcC1lbW1jLmMKPj4+IGluZGV4IDg4N2I0YzIuLjNm NTVjMGQgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL3BoeS9waHktcm9ja2NoaXAtZW1tYy5jCj4+ PiArKysgYi9kcml2ZXJzL3BoeS9waHktcm9ja2NoaXAtZW1tYy5jCj4+PiBAQCAtMTg2LDcgKzE4 Niw3IEBAIHN0YXRpYyBpbnQgcm9ja2NoaXBfZW1tY19waHlfcHJvYmUoc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqcGRldikKPj4+ICAgCWlmICghcmtfcGh5KQo+Pj4gICAJCXJldHVybiAtRU5PTUVN Owo+Pj4KPj4+IC0JaWYgKG9mX3Byb3BlcnR5X3JlYWRfdTMyKGRldi0+b2Zfbm9kZSwgInJlZyIs ICZyZWdfb2Zmc2V0KSkgewo+Pj4gKwlpZiAob2ZfcHJvcGVydHlfcmVhZF91MzIoZGV2LT5vZl9u b2RlLCAicmVnX29mZnNldCIsICZyZWdfb2Zmc2V0KSkgewo+Pj4gICAJCWRldl9lcnIoZGV2LCAi bWlzc2luZyByZWcgcHJvcGVydHkgaW4gbm9kZSAlc1xuIiwKPj4+ICAgCQkJZGV2LT5vZl9ub2Rl LT5uYW1lKTsKPj4+ICAgCQlyZXR1cm4gLUVJTlZBTDsKPj4+Cj4KPgo+CgoKLS0gCkJlc3QgUmVn YXJkcwpTaGF3biBMaW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbcDHBPI (ORCPT ); Thu, 7 Apr 2016 21:15:08 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:60706 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932246AbcDHBPE (ORCPT ); Thu, 7 Apr 2016 21:15:04 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] phy: rockchip-emmc: fix compile issue on arm64 platform To: Kishon Vijay Abraham I References: <1457425453-1996-1-git-send-email-shawn.lin@rock-chips.com> <570659EA.9000706@ti.com> <57066137.4040807@ti.com> Cc: shawn.lin@rock-chips.com, linux-kernel@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org From: Shawn Lin Message-ID: <570705FE.2000202@rock-chips.com> Date: Fri, 8 Apr 2016 09:14:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <57066137.4040807@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/4/7 21:31, Kishon Vijay Abraham I 写道: > Hi, > > On Thursday 07 April 2016 06:30 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 08 March 2016 01:54 PM, Shawn Lin wrote: >>> This patch rename "reg" property to "reg_offset". >>> We rename it to fix the compile issue on ARM64 platform: >>> (reg_format): "reg" property in /phy has invalid length (4 bytes) >>> (#address-cells == 2, #size-cells == 2) >> >> Is the same node used for both ARM32 and ARM64 platforms? >> >> Thanks >> Kishon >>> >>> This's because "reg" is very special one which should keep the >>> *-cells with its parent node and can't be overwrited even if we >>> do that explicitly. On 32-bit plafform, the default *-cells >>> fit for what we assign to "reg". But that's not correct for 64-bit >>> platform. So we can see two possible solutions to fix this problem: >>> A) make phy-rockchip-emmc as a child phy node and overwrite its >>> parent's #address-cells and #size-cells. >>> B) avoid using this special property. >>> >>> we use it just for passing on a offset for different Socs, and there's >>> no requirement to change the code to make phy-rockchip-emmc as a child >>> node. so choose option B) is sane. > > I just looked at the Heiko's patch and it makes more sense to have the binding > that he described in his patch [1]. Can you fix it accordingly? yes, Heiko's patch is more reasonable to me. With his patch applied, this issue is gone if assigning address-cells in dt for grf. So we can drop this patch. > > I seem to have only this patch and Heiko's patch for this -rc cycle. Once you > send your patch, I can send a pull request to Greg. > > Thanks > Kishon > > [1]- > https://patchwork.ozlabs.org/patch/601580/ >>> >>> Signed-off-by: Shawn Lin >>> --- >>> >>> Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 4 ++-- >>> drivers/phy/phy-rockchip-emmc.c | 2 +- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt >>> index 61916f1..ed964ef 100644 >>> --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt >>> +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt >>> @@ -6,7 +6,7 @@ Required properties: >>> - rockchip,grf : phandle to the syscon managing the "general >>> register files" >>> - #phy-cells: must be 0 >>> - - reg: PHY configure reg address offset in "general >>> + - reg_offset: PHY configure reg address offset in "general >>> register files" >>> >>> Example: >>> @@ -14,6 +14,6 @@ Example: >>> emmcphy: phy { >>> compatible = "rockchip,rk3399-emmc-phy"; >>> rockchip,grf = <&grf>; >>> - reg = <0xf780>; >>> + reg_offset = <0xf780>; >>> #phy-cells = <0>; >>> }; >>> diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c >>> index 887b4c2..3f55c0d 100644 >>> --- a/drivers/phy/phy-rockchip-emmc.c >>> +++ b/drivers/phy/phy-rockchip-emmc.c >>> @@ -186,7 +186,7 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev) >>> if (!rk_phy) >>> return -ENOMEM; >>> >>> - if (of_property_read_u32(dev->of_node, "reg", ®_offset)) { >>> + if (of_property_read_u32(dev->of_node, "reg_offset", ®_offset)) { >>> dev_err(dev, "missing reg property in node %s\n", >>> dev->of_node->name); >>> return -EINVAL; >>> > > > -- Best Regards Shawn Lin