From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues Date: Fri, 8 Apr 2016 16:03:12 +0900 Message-ID: <570757B0.9080300@igel.co.jp> References: <1459988946-5956-1-git-send-email-rich.lane@bigswitch.com> <20160407154235.GD3080@yliu-dev.sh.intel.com> <6607494.IC538dk6LI@xps13> <57070D3D.2070700@igel.co.jp> <20160408061458.GF3080@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , Rich Lane , dev@dpdk.org To: Yuanhan Liu Return-path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 9876528F2 for ; Fri, 8 Apr 2016 09:03:14 +0200 (CEST) Received: by mail-pa0-f53.google.com with SMTP id td3so69807926pab.2 for ; Fri, 08 Apr 2016 00:03:14 -0700 (PDT) In-Reply-To: <20160408061458.GF3080@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2016/04/08 15:14, Yuanhan Liu wrote: > On Fri, Apr 08, 2016 at 10:45:33AM +0900, Tetsuya Mukawa wrote: >> On 2016/04/08 2:20, Thomas Monjalon wrote: >>>>> If the vhost PMD were configured with more queues than the guest, the old >>>>> code would segfault in rte_vhost_enable_guest_notification due to a NULL >>>>> virtqueue pointer. >>>>> >>>>> Fixes: ee584e9710b9 ("vhost: add driver on top of the library") >>>>> Signed-off-by: Rich Lane >>>> Acked-by: Yuanhan Liu >>> Applied, thanks >> Hi Rich and Yuanhan, >> >> I am sorry for late reply. I was out of office yesterday. > Tetsuya, no worry! Man takes leaves, and isn't the reason we have 2 or > more maintainers on some blocks? :) > > --yliu Yeah, thanks! Tetsuya