Re: [PATCH 0/2 v2] Warn if module name different than output filename

[Petr Lautrbach <plautrba@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1542 bytes --]

On 04/07/2016 05:06 PM, James Carter wrote:
> Since CIL treats files as modules and does not have a separate
> module statement it can cause confusion when a Refpolicy module
> has a name that is not the same as its base filename because older
> SELinux userspaces will refer to the module by its module name while
> a CIL-based userspace will refer to it by its filename.
> 
> Because of this, provide a warning message when converting a policy
> package to CIL or compiling a module and the output filename is different
> than the module name.

Would it be feasible to use a module statement name as a new base name
for CIL module instead of the original base pp filename, and warn users
that the new output filename is different from the original?

It would help to have same installed module names in 'semodule -l' list
in older and current userspace.


> 
> Changes from v1:
> - Added a "Warning:" prefix
> - Removed checks against the input filename
> - Since there are now only two checks and the base filename is used in the
> warning message, it no longer made sense to create common helper functions
> in libsepol.
> 
> James Carter (2):
>   policycoreutils/hll/pp: Warn if module name different than output
>     filename
>   checkpolicy: Warn if module name different than output filename
> 
>  checkpolicy/checkmodule.c   | 15 +++++++++++++++
>  policycoreutils/hll/pp/pp.c | 28 ++++++++++++++++++++++++----
>  2 files changed, 39 insertions(+), 4 deletions(-)
> 


-- 
Petr Lautrbach



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]