From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaroslav Kysela Subject: Re: [PATCH - alsa-lib 1/1] Change card/pid get functions to return -ENOSYS if the kernel is too old Date: Fri, 8 Apr 2016 14:56:28 +0200 Message-ID: <5707AA7C.5030804@perex.cz> References: <1459532030-6387-1-git-send-email-agoode@google.com> <20160401211558.GA20661@mail.zuhause> <20160407201041.GB26683@mail.zuhause> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail1.perex.cz (mail1.perex.cz [77.48.224.245]) by alsa0.perex.cz (Postfix) with ESMTP id B9DE6265132 for ; Fri, 8 Apr 2016 14:56:29 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai , Martin Koegler Cc: Adam Goode , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Dne 8.4.2016 v 12:24 Takashi Iwai napsal(a): > On Thu, 07 Apr 2016 22:10:41 +0200, > Martin Koegler wrote: >> >> On Thu, Apr 07, 2016 at 03:23:01PM -0400, Adam Goode wrote: >>> Have you heard any objections? >>> >>> Also, would you plan to do a 1.1.2 release soon after accepting this, to >>> get this functionality out quickly? >> >> Distributions already start to pick 1.1.1 up: >> https://build.opensuse.org/request/show/382608 >> https://build.opensuse.org/request/show/382611 >> >> I would object merging that patch, if there is no immediate patched 1.1.2 release available, >> as otherwise 1.1.1 with a different API will get used by the mass. > > I have no strong opinion on this, so far. Either way (a quick 1.1.2 > fix release, or introducing a new function in 1.1.2) isn't a big > deal. Maybe the former is easier, but the latter is safer. > > Jaroslav, what's your take? > (And no, let's not use the versioned symbols again :) What about 1.1.1.2 ? This + "pcm_plugin: fix appl pointer not correct when mmap_commit() return error" patch ? Jaroslav -- Jaroslav Kysela Linux Sound Maintainer; ALSA Project; Red Hat, Inc.