Re: [PATCH v3 0/5] xentrace/xenalyze Support on ARM

[George Dunlap <george.dunlap@citrix.com>]

On 05/04/16 09:09, Jan Beulich wrote:
>>>> On 04.04.16 at 20:48, <ben.sanda@dornerworks.com> wrote:
>> This patch set adds support for xentrace/xenalyze to the ARM platform.
>>
>> The Xen heap memory mapping, timestamping, and P2M translation needed
>> by xentrace is corrected for operation on the ARM platform using the
>> x86 platform as reference. Trace buffer initialization is added to
>> setup.c, XENMAPSPACE_gmfn_foreign page mapping and address translation
>> for DOMID_XEN is corrected in mm.c and p2m.c, and timestamping for the
>> trace buffers is corrected in time.c/.h.
>>
>> Finally the xenaylze makefile is configured to build the tool for ARM.
>>
>> ---
>> Changed since v2:
>>   * Merged previous single file patches into atomic patches which can
>>     be applied and compiled independently. 
>>   * Updated individual patch names to be more descriptive.
>>   * Correct order of patches in patch set to provide correct
>>     application/build order.
>>
>> ---
>> Changed since v1:
>>   * Removed Flask changes as deemed unnecessary and unclear in 
>>     purpose
>>   * Corrected all commit messages to be line limited to 72 chars
>>   * Implemented v1 review comments as indicated in each file's
>>     commit log.
>>
>> Benjamin Sanda (5):
>>   xentrace: Common Support for get_pg_owner/put_pg_owner on ARM and x86
>>   xentrace: Memory/Page Mapping support for DOMID_XEN on ARM
>>   xentrace: Timestamp support for ARM platform
>>   xentrace: Trace Buffer Initialization on ARM
>>   xenalyze: Build for Both ARM and x86 Platforms
>>
>>  tools/xentrace/Makefile    |  3 +--
>>  xen/arch/arm/mm.c          |  3 ++-
>>  xen/arch/arm/p2m.c         | 35 +++++++++++++++++++++++++++----
>>  xen/arch/arm/setup.c       |  3 +++
>>  xen/arch/arm/time.c        |  9 +++++++-
>>  xen/arch/x86/mm.c          | 48 -------------------------------------------
>>  xen/common/page_alloc.c    | 51 ++++++++++++++++++++++++++++++++++++++++++++++
>>  xen/include/asm-arm/time.h | 11 +++++-----
>>  xen/include/xen/mm.h       |  2 ++
>>  9 files changed, 103 insertions(+), 62 deletions(-)
> 
> A couple of formal things: This is v3, and I only now notice indeed
> I should have looked at some of the patches. Yet which of them
> isn't clear - I'm being Cc-ed on all of them, instead of just the ones
> that submission guidelines say I should be. And then all patch
> subjects start with xenalyze: or xentrace:, suggesting this series
> isn't touching code other than those two. Generalization of
> {get,put}_pg_owner(), otoh, while apparently a prereq for the
> generalization of one or both of the two, should use a more
> indicative component prefix (or maybe even none at all).

To make things a bit more concrete, here might be a better set of
one-line descriptions that help people skimming figure out what pertains
to them and what's going on:

[1/5] xen: Move {get,put}_pg_owner() into common code
[2/5] xen/arm: Support mapping pages owned by DOMID_XEN
[3/5] xen/arm: Have get_cycles() use the hardware timestamp counter
[4/5] xen/arm: Enable tracing
[5/5] tools/xenalyze: Build on ARM

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel