From: santosh shilimkar <santosh.shilimkar@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: shamir.rabinovitch@oracle.com, rds-devel@oss.oracle.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v4 1/2] RDS: memory allocated must be align to 8
Date: Fri, 8 Apr 2016 13:55:17 -0700 [thread overview]
Message-ID: <57081AB5.5030703@oracle.com> (raw)
In-Reply-To: <20160408.161055.212162741537870508.davem@davemloft.net>
On 4/8/2016 1:10 PM, David Miller wrote:
> From: santosh shilimkar <santosh.shilimkar@oracle.com>
> Date: Fri, 8 Apr 2016 12:44:39 -0700
>
>> On 4/7/2016 4:57 AM, Shamir Rabinovitch wrote:
>>> Fix issue in 'rds_ib_cong_recv' when accessing unaligned memory
>>> allocated by 'rds_page_remainder_alloc' using uint64_t pointer.
>>>
>> Sorry I still didn't follow this change still. What exactly is the
>> problem.
>
> You can't stop the offset at non-8byte intervals, because the chunks
> being used in these arenas can have 64-bit values in it, which must be
> 8-byte aligned.
>
I see. Thanks for explaining it Dave.
Its fine to apply then.
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Regards,
Santosh
prev parent reply other threads:[~2016-04-08 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 11:57 [PATCH v4 1/2] RDS: memory allocated must be align to 8 Shamir Rabinovitch
2016-04-07 11:57 ` [PATCH v4 2/2] RDS: fix congestion map corruption for PAGE_SIZE > 4k Shamir Rabinovitch
2016-04-08 19:39 ` santosh shilimkar
2016-04-08 19:44 ` [PATCH v4 1/2] RDS: memory allocated must be align to 8 santosh shilimkar
2016-04-08 20:10 ` David Miller
2016-04-08 20:55 ` santosh shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57081AB5.5030703@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=shamir.rabinovitch@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.