From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tom G. Christensen" Subject: Re: git segfaults on older Solaris releases Date: Sat, 9 Apr 2016 09:02:38 +0200 Message-ID: <5708A90E.1050705@jupiterrise.com> References: <5706A489.7070101@jupiterrise.com> <5706C0D4.9030707@jupiterrise.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org, Jeff King To: Junio C Hamano X-From: git-owner@vger.kernel.org Sat Apr 09 09:03:07 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aomvC-00064V-Tb for gcvg-git-2@plane.gmane.org; Sat, 09 Apr 2016 09:03:07 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751639AbcDIHCq (ORCPT ); Sat, 9 Apr 2016 03:02:46 -0400 Received: from sub4.mail.dreamhost.com ([69.163.253.135]:34497 "EHLO homiemail-a97.g.dreamhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbcDIHCp (ORCPT ); Sat, 9 Apr 2016 03:02:45 -0400 Received: from homiemail-a97.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a97.g.dreamhost.com (Postfix) with ESMTP id CC3B728607C; Sat, 9 Apr 2016 00:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jupiterrise.com; h=subject :to:references:cc:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=jupiterrise.com; bh=f yJFnUgLimQSoNBYf74M5A02EVM=; b=qxmbLHuLlNNVXRZzHmyUlY34nGYi2r57D E0JQPpmTk2swkDjM9wuUhTiu3+AIXHmGmKkt0fn/FEcqFoeJbxsKXlIftvLgKl+q W6ZNWH+0AgYnP25Il7dMhWyO7BUrI9JVBk4LZoMDfYE/0SwTB0qs/lWO4wkmhf0T yDPLgzIqzI= Received: from localhost6.localdomain6 (2-106-159-182-static.dk.customer.tdc.net [2.106.159.182]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tgc99@jupiterrise.com) by homiemail-a97.g.dreamhost.com (Postfix) with ESMTPSA id 548F6286058; Sat, 9 Apr 2016 00:02:44 -0700 (PDT) Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost6.localdomain6 (8.14.4/8.14.4) with ESMTP id u3972cLe027580; Sat, 9 Apr 2016 09:02:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 In-Reply-To: <5706C0D4.9030707@jupiterrise.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On 07/04/16 22:19, Tom G. Christensen wrote: > On 07/04/16 20:50, Junio C Hamano wrote: >> Junio C Hamano writes: >> So perhaps this is all we need to fix your box. >> >> setup.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > I applied this patch to 2.8.0 and have completed a testsuite run on > Solaris 2.6/x86 with only a few unrelated problems. > I will continue testing on the other Solaris < 10 releases but I do not > expect any difference in the outcome. > I've finished testing 2.8.1 and I found one more case where a null is being printed and causing a segfault. This happens even on Solaris 8 and 9. The failling test is t3200.63. Here is the backtrace from a Solaris 8/SPARC machine: (gdb) core trash directory.t3200-branch/core [New LWP 1] [Thread debugging using libthread_db enabled] [New Thread 1 (LWP 1)] Core was generated by `/export/home/tgc/buildpkg/git/src/git-2.8.1/git branch --unset-upstream'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0xfecb32cc in strlen () from /usr/lib/libc.so.1 (gdb) bt #0 0xfecb32cc in strlen () from /usr/lib/libc.so.1 #1 0xfed06508 in _doprnt () from /usr/lib/libc.so.1 #2 0xfed08690 in vfprintf () from /usr/lib/libc.so.1 #3 0x001487bc in vreportf (prefix=, err=, params=0xffbfe408) at usage.c:23 #4 0x0014881c in die_builtin (err=0x198f90 "Could not set '%s' to '%s'", params=0xffbfe408) at usage.c:35 #5 0x00148934 in die (err=0x198f90 "Could not set '%s' to '%s'") at usage.c:108 #6 0x000af1b0 in git_config_set_multivar_in_file (value=0x0, key=0x1ecca0 "branch.master.remote", config_filename=, value_regex=, multi_replace=) at config.c:2226 #7 git_config_set_multivar_in_file (config_filename=0x0, key=0x1ecca0 "branch.master.remote", value=0x0, value_regex=0x0, multi_replace=1) at config.c:2220 #8 0x0003aa6c in cmd_branch (argc=0, argv=0xffbfec00, prefix=) at builtin/branch.c:793 #9 0x000255e8 in run_builtin (argv=0xffbfec00, argc=2, p=0x1c365c ) at git.c:353 #10 handle_builtin (argc=2, argv=0xffbfec00) at git.c:540 #11 0x00168ecc in run_argv (argv=0xffbfeb30, argcp=0xffbfebdc) at git.c:594 #12 main (argc=2, av=) at git.c:701 (gdb) -tgc