From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=uUj84bo2WS/C9jwnBAJZn2y3rCmDMKCSmmmiHIZTzVg=; b=E0ZKnTwbKUAuqm17LoS7B+o/suZJKKylR7+a4aYUbT5CIge/WcY9BlP8z9F9LYlt2I 0HOCMys2pYTzCZmUNdZ+KDcbCltlCGuMkqNj2gVOWKNDAIiv9hrSlLKwIJ9vLT/60eaE li6GXQVKmAPfhcMt8rVfylTxfcJuFG20pheYo= References: <6e2cf6821542a253904dfc7d8ec431d6bbda2b4e.1460131308.git.lucien.xin@gmail.com> <6197a35a2eb6df2caf90edcbf1b49da12077f659.1460131308.git.lucien.xin@gmail.com> <8c14a891d0a8bcea071d4e5305776a5c5cd9fd17.1460131308.git.lucien.xin@gmail.com> From: Nikolay Aleksandrov Message-ID: <5708F6B1.1010109@cumulusnetworks.com> Date: Sat, 9 Apr 2016 14:33:53 +0200 MIME-Version: 1.0 In-Reply-To: <8c14a891d0a8bcea071d4e5305776a5c5cd9fd17.1460131308.git.lucien.xin@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xin Long , network dev , bridge@lists.linux-foundation.org Cc: davem@davemloft.net On 04/08/2016 06:03 PM, Xin Long wrote: > There are some repetitive codes in stp_state_store, we can remove > them by calling store_bridge_parm. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 24 +++++++++--------------- > 1 file changed, 9 insertions(+), 15 deletions(-) > Reviewed-by: Nikolay Aleksandrov From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov via Bridge Subject: Re: [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm Date: Sat, 9 Apr 2016 14:33:53 +0200 Message-ID: <5708F6B1.1010109@cumulusnetworks.com> References: <6e2cf6821542a253904dfc7d8ec431d6bbda2b4e.1460131308.git.lucien.xin@gmail.com> <6197a35a2eb6df2caf90edcbf1b49da12077f659.1460131308.git.lucien.xin@gmail.com> <8c14a891d0a8bcea071d4e5305776a5c5cd9fd17.1460131308.git.lucien.xin@gmail.com> Reply-To: Nikolay Aleksandrov Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net To: Xin Long , network dev , bridge@lists.linux-foundation.org Return-path: In-Reply-To: <8c14a891d0a8bcea071d4e5305776a5c5cd9fd17.1460131308.git.lucien.xin@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 04/08/2016 06:03 PM, Xin Long wrote: > There are some repetitive codes in stp_state_store, we can remove > them by calling store_bridge_parm. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 24 +++++++++--------------- > 1 file changed, 9 insertions(+), 15 deletions(-) > Reviewed-by: Nikolay Aleksandrov