From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Date: Sat, 09 Apr 2016 15:19:44 +0000 Subject: Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag Message-Id: <57091D90.4030905@mojatatu.com> List-Id: References: <1460178984.6473.473.camel@edumazet-glaptop3.roam.corp.google.com> In-Reply-To: <1460178984.6473.473.camel@edumazet-glaptop3.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Eric Dumazet , Xin Long Cc: network dev , linux-sctp@vger.kernel.org, Marcelo Ricardo Leitner , Vlad Yasevich , daniel@iogearbox.net, davem@davemloft.net On 16-04-09 01:16 AM, Eric Dumazet wrote: > > Lots of holes in this structure... > > I may have mentioned to you that there is 8 bit hole in tcp_info too ;-> (above tcpi_rto). Adding an 8 bit explicit pad seems useful since it is already in the wild. I was going to send the patch after netdev11 but forgot. cheers, jamal From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag Date: Sat, 9 Apr 2016 11:19:44 -0400 Message-ID: <57091D90.4030905@mojatatu.com> References: <1460178984.6473.473.camel@edumazet-glaptop3.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: network dev , linux-sctp@vger.kernel.org, Marcelo Ricardo Leitner , Vlad Yasevich , daniel@iogearbox.net, davem@davemloft.net To: Eric Dumazet , Xin Long Return-path: Received: from mail-io0-f171.google.com ([209.85.223.171]:32815 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbcDIPTq (ORCPT ); Sat, 9 Apr 2016 11:19:46 -0400 Received: by mail-io0-f171.google.com with SMTP id o126so140988825iod.0 for ; Sat, 09 Apr 2016 08:19:46 -0700 (PDT) In-Reply-To: <1460178984.6473.473.camel@edumazet-glaptop3.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On 16-04-09 01:16 AM, Eric Dumazet wrote: > > Lots of holes in this structure... > > I may have mentioned to you that there is 8 bit hole in tcp_info too ;-> (above tcpi_rto). Adding an 8 bit explicit pad seems useful since it is already in the wild. I was going to send the patch after netdev11 but forgot. cheers, jamal