From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>,
Jerin Jacob <jerinjacobk@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>,
David Marchand <david.marchand@redhat.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] build: remove special handling for node library
Date: Thu, 02 Jul 2020 12:21:17 +0200 [thread overview]
Message-ID: <5709908.s6xYseIpxj@thomas> (raw)
In-Reply-To: <CALBAE1NjkSUvYhN7yFBJ1iU2z-T=043=8QtmYc5WC=4LGmRoPw@mail.gmail.com>
02/07/2020 11:53, Jerin Jacob:
> On Thu, Jul 2, 2020 at 2:48 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Wed, Jul 01, 2020 at 08:05:06PM +0200, Thomas Monjalon wrote:
> > > What is the point of adding librte_node a second time separately?
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> >
> > I suspect that this is a hangover from when we did not explicitly
> > link_whole all DPDK libs.
>
> Yes. The constructor functions are not getting linked if there is NO
> dependency from this library.
OK, so I can change the commit log to explain that it is not needed
anymore because we link whole, including register.
next prev parent reply other threads:[~2020-07-02 10:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 18:05 [dpdk-dev] [PATCH] build: remove special handling for node library Thomas Monjalon
2020-07-02 9:17 ` Bruce Richardson
2020-07-02 9:53 ` Jerin Jacob
2020-07-02 10:21 ` Thomas Monjalon [this message]
2020-07-02 16:09 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-07-04 14:22 ` Jerin Jacob
2020-07-05 10:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5709908.s6xYseIpxj@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.