From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/3] package/radlib: kconfig and makefile
Date: Sun, 10 Apr 2016 16:59:14 +0200 [thread overview]
Message-ID: <570A6A42.1090703@mind.be> (raw)
In-Reply-To: <1460046983.3710.12.camel@intel.com>
On 04/07/16 18:36, Kinsella, Ray wrote:
> On Thu, 2016-04-07 at 17:25 +0200, Arnout Vandecappelle wrote:
>>> Confused, just doing what I was asked in the previous review.
>>> Can you offer a little more guidance on how I should structure.
>>
>> You misunderstood the patches that Thomas was refering to. There
>> should be a
>> single PATCH v5 that you send to the buildroot mailing list, which
>> contains
>> Config.in, radlib.mk, radlib.hash, and at least 3 ....patch files.
>
> ok I get it ... your point about the build being broken between patches
> makes perfect sense.
>
> So a single email PATCH v3 patching radlib.mk, Config.in, radlib.hash
> and three patches. On the 3 patches, can we define what these look
> like...
>
> 1. Patch to introduce pkg-config for sqlite and postgresql.
> 2. Patch to introduce mysql-config.
> 3. Patch to fix the paths in the subdir-objects.
>
> Accurate, make sense?
Yes, makes sense.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-04-10 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 13:19 [Buildroot] [PATCH v4 0/3] package/radlib: new package ray.kinsella at intel.com
2016-04-06 13:19 ` [Buildroot] [PATCH v4 1/3] package/radlib: kconfig and makefile ray.kinsella at intel.com
2016-04-06 22:20 ` Arnout Vandecappelle
2016-04-07 11:04 ` Kinsella, Ray
2016-04-07 15:25 ` Arnout Vandecappelle
2016-04-07 16:36 ` Kinsella, Ray
2016-04-10 14:59 ` Arnout Vandecappelle [this message]
2016-04-11 8:45 ` Kinsella, Ray
2016-04-06 13:19 ` [Buildroot] [PATCH v4 2/3] package/radlib: Renamed configure.in to configure.ac ray.kinsella at intel.com
2016-04-06 22:22 ` Arnout Vandecappelle
2016-04-07 12:04 ` Kinsella, Ray
2016-04-06 13:19 ` [Buildroot] [PATCH v4 3/3] package/radlib: reworked autotools with pkg-config ray.kinsella at intel.com
2016-04-06 22:36 ` Arnout Vandecappelle
2016-04-07 12:03 ` Kinsella, Ray
2016-04-07 15:39 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570A6A42.1090703@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.