From: Peter Hurley <peter@hurleysoftware.com>
To: Jiri Slaby <jslaby@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] tty: Remove stale parameter comment
Date: Sun, 10 Apr 2016 11:49:09 -0700 [thread overview]
Message-ID: <570AA025.1010200@hurleysoftware.com> (raw)
In-Reply-To: <570A0DA9.7060301@suse.cz>
On 04/10/2016 01:24 AM, Jiri Slaby wrote:
> On 04/10/2016, 05:36 AM, Peter Hurley wrote:
>> noctty was removed as a parameter by commit 216513411937586
>
> It is actually 11e1d4aa4da.
Right; not sure where that number came from.
>
>> ("tty: Consolidate noctty check in tty_open()").
>>
>> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
>> ---
>> drivers/tty/tty_io.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
>> index 3cdd63b..50979be 100644
>> --- a/drivers/tty/tty_io.c
>> +++ b/drivers/tty/tty_io.c
>> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
>> * tty_lookup_driver - lookup a tty driver for a given device file
>> * @device: device number
>> * @filp: file pointer to tty
>> - * @noctty: set if the device should not become a controlling tty
>> * @index: index for the device in the @return driver
>> * @return: driver for this inode (with increased refcount)
>> *
>>
>
>
prev parent reply other threads:[~2016-04-10 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 3:36 [PATCH 1/2] tty: Remove unused TTY_NUMBER() macro Peter Hurley
2016-04-10 3:36 ` [PATCH 2/2] tty: Remove stale parameter comment Peter Hurley
2016-04-10 8:24 ` Jiri Slaby
2016-04-10 18:49 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570AA025.1010200@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.