From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH 1/2] drm/rockchip: remove redundant statement Date: Mon, 11 Apr 2016 10:52:33 +0800 Message-ID: <570B1171.7040402@rock-chips.com> References: <1459864232-25033-1-git-send-email-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1459864232-25033-1-git-send-email-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDA05pyIMDXml6UgMjE6NTAsIEpvaG4gS2VlcGluZyB3cm90ZToKPiBUaGUgY2Fs bCB0byBhcm1faW9tbXVfZGV0YWNoX2RldmljZSgpIG9uIHRoZSBwcmV2aW91cyBsaW5lIHNldHMK PiBkZXYtPmFyY2hkYXRhLm1hcHBpbmcgdG8gTlVMTCBzbyB0aGlzIGNhbGwgaXMgYWx3YXlzIGEg bm8tb3AuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKb2huIEtlZXBpbmcgPGpvaG5AbWV0YW5hdGUuY29t Pgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYyB8 IDEgLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYwo+IGluZGV4IGY1NTZhOGYuLjc2OTVjNzkg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMKPiBA QCAtMjQ0LDcgKzI0NCw2IEBAIHN0YXRpYyBpbnQgcm9ja2NoaXBfZHJtX3VubG9hZChzdHJ1Y3Qg ZHJtX2RldmljZSAqZHJtX2RldikKPiAgIAlkcm1fa21zX2hlbHBlcl9wb2xsX2ZpbmkoZHJtX2Rl dik7Cj4gICAJY29tcG9uZW50X3VuYmluZF9hbGwoZGV2LCBkcm1fZGV2KTsKPiAgIAlhcm1faW9t bXVfZGV0YWNoX2RldmljZShkZXYpOwo+IC0JYXJtX2lvbW11X3JlbGVhc2VfbWFwcGluZyhkZXYt PmFyY2hkYXRhLm1hcHBpbmcpOwo+ICAgCWRybV9tb2RlX2NvbmZpZ19jbGVhbnVwKGRybV9kZXYp Owo+ICAgCWRybV9kZXYtPmRldl9wcml2YXRlID0gTlVMTDsKPiAgIApBcHBsaWVkIHRvIG15IGRy bS1maXhlcwoKVGhhbmtzLjotKQoKLS0gCu+8rWFyayBZYW8KCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Mon, 11 Apr 2016 10:52:33 +0800 Subject: [PATCH 1/2] drm/rockchip: remove redundant statement In-Reply-To: <1459864232-25033-1-git-send-email-john@metanate.com> References: <1459864232-25033-1-git-send-email-john@metanate.com> Message-ID: <570B1171.7040402@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?04?05? 21:50, John Keeping wrote: > The call to arm_iommu_detach_device() on the previous line sets > dev->archdata.mapping to NULL so this call is always a no-op. > > Signed-off-by: John Keeping > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index f556a8f..7695c79 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -244,7 +244,6 @@ static int rockchip_drm_unload(struct drm_device *drm_dev) > drm_kms_helper_poll_fini(drm_dev); > component_unbind_all(dev, drm_dev); > arm_iommu_detach_device(dev); > - arm_iommu_release_mapping(dev->archdata.mapping); > drm_mode_config_cleanup(drm_dev); > drm_dev->dev_private = NULL; > Applied to my drm-fixes Thanks.:-) -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbcDKCws (ORCPT ); Sun, 10 Apr 2016 22:52:48 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:45424 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbcDKCwq (ORCPT ); Sun, 10 Apr 2016 22:52:46 -0400 X-263anti-spam: BIG:0;ABS:1;DNS:0;ATT:0;SPF:S;KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <570B1171.7040402@rock-chips.com> Date: Mon, 11 Apr 2016 10:52:33 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: John Keeping CC: Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/rockchip: remove redundant statement References: <1459864232-25033-1-git-send-email-john@metanate.com> In-Reply-To: <1459864232-25033-1-git-send-email-john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年04月05日 21:50, John Keeping wrote: > The call to arm_iommu_detach_device() on the previous line sets > dev->archdata.mapping to NULL so this call is always a no-op. > > Signed-off-by: John Keeping > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index f556a8f..7695c79 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -244,7 +244,6 @@ static int rockchip_drm_unload(struct drm_device *drm_dev) > drm_kms_helper_poll_fini(drm_dev); > component_unbind_all(dev, drm_dev); > arm_iommu_detach_device(dev); > - arm_iommu_release_mapping(dev->archdata.mapping); > drm_mode_config_cleanup(drm_dev); > drm_dev->dev_private = NULL; > Applied to my drm-fixes Thanks.:-) -- Ｍark Yao