From: Pavel Emelyanov <xemul@virtuozzo.com>
To: Mathias Krause <minipli@googlemail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH net] packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface
Date: Mon, 11 Apr 2016 11:58:35 +0300 [thread overview]
Message-ID: <570B673B.7020705@virtuozzo.com> (raw)
In-Reply-To: <1460285548-832-1-git-send-email-minipli@googlemail.com>
On 04/10/2016 01:52 PM, Mathias Krause wrote:
> Because we miss to wipe the remainder of i->addr[] in packet_mc_add(),
> pdiag_put_mclist() leaks uninitialized heap bytes via the
> PACKET_DIAG_MCLIST netlink attribute.
>
> Fix this by explicitly memset(0)ing the remaining bytes in i->addr[].
>
> Fixes: eea68e2f1a00 ("packet: Report socket mclist info via diag module")
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: Pavel Emelyanov <xemul@parallels.com>
Acked-by: Pavel Emelyanov <xemul@virtuozzo.com>
next prev parent reply other threads:[~2016-04-11 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 10:52 [PATCH net] packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface Mathias Krause
2016-04-11 8:58 ` Pavel Emelyanov [this message]
2016-04-14 4:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B673B.7020705@virtuozzo.com \
--to=xemul@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=minipli@googlemail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.