From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stefan Christ <s.christ@phytec.de>, linux-mtd@lists.infradead.org
Cc: han.xu@nxp.com, eliedebrauwer@gmail.com, shijie8@gmail.com,
mpa@pengutronix.de, ptx kernel <kernel@pengutronix.de>
Subject: Re: [PATCH] mtd: gpmi: Deal with bitflips in erased regions
Date: Mon, 11 Apr 2016 15:08:04 +0200 [thread overview]
Message-ID: <570BA1B4.8060806@pengutronix.de> (raw)
In-Reply-To: <1458030937-4245-1-git-send-email-s.christ@phytec.de>
[-- Attachment #1.1: Type: text/plain, Size: 1513 bytes --]
On 03/15/2016 09:35 AM, Stefan Christ wrote:
> From: Elie De Brauwer <eliedebrauwer@gmail.com>
>
> The BCH block typically used with a GPMI block on an i.MX28/i.MX6 is only
> able to correct bitflips on data actually streamed through the block.
> When erasing a block the data does not stream through the BCH block
> and therefore no ECC data is written to the NAND chip. This causes
> gpmi_ecc_read_page to return failure as soon as a single non-1-bit is
> found in an erased page. Typically causing problems at higher levels
> (ubifs corrupted empty space warnings). This problem was also observed
> when using SLC NAND devices.
>
> This patch configures the BCH block to mark a block as 'erased' if
> not too much bitflips are found (by setting the erase threshold). A
> consequence of this is that whenever an erased page is read, the
> number of bitflips will be counted and corrected in software,
> allowing the upper layers to take proper actions.
>
> Signed-off-by: Elie De Brauwer <eliedebrauwer@gmail.com>
> Acked-by: Peter Korsgaard <peter@korsgaard.com>
> Acked-by: Huang Shijie <b32955@freescale.com>
You moght want to coordinate with Markus (Cc'ed) as he tries to solve
the same issue.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-04-11 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 8:35 [PATCH] mtd: gpmi: Deal with bitflips in erased regions Stefan Christ
2016-04-11 11:18 ` Stefan Christ
2016-04-11 11:54 ` Boris Brezillon
2016-04-15 7:49 ` Markus Pargmann
2016-04-11 13:08 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BA1B4.8060806@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=eliedebrauwer@gmail.com \
--cc=han.xu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=mpa@pengutronix.de \
--cc=s.christ@phytec.de \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.