All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Chunyan Liu <cyliu@suse.com>
Subject: Re: [PATCH for-4.7] libxl: pvusb: use %u to convert unsigned number
Date: Mon, 11 Apr 2016 15:16:09 +0200	[thread overview]
Message-ID: <570BA399.3060100@suse.com> (raw)
In-Reply-To: <1460380083-14534-1-git-send-email-wei.liu2@citrix.com>

On 11/04/16 15:08, Wei Liu wrote:
> Both be_domid and fe_domid are unsigned.
> 
> Reported-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Chunyan Liu <cyliu@suse.com>
> ---
>  tools/libxl/libxl_pvusb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c
> index c66733b..9f1e842 100644
> --- a/tools/libxl/libxl_pvusb.c
> +++ b/tools/libxl/libxl_pvusb.c
> @@ -350,7 +350,7 @@ static const char *vusb_be_from_xs_fe(libxl__gc *gc, const char *fe_path,
>  
>      /* Check to see that it has the proper form, and that fe_domid ==
>       * target domid */
> -    r = sscanf(be_path, "/local/domain/%d/backend/%15[^/]/%d",
> +    r = sscanf(be_path, "/local/domain/%u/backend/%15[^/]/%u",
>                 &be_domid, be_type, &fe_domid);
>  
>      if (r != 3 || fe_domid != tgt_domid) {
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-11 13:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 13:08 [PATCH for-4.7] libxl: pvusb: use %u to convert unsigned number Wei Liu
2016-04-11 13:16 ` Juergen Gross [this message]
2016-04-22 14:44   ` Ian Jackson
2016-04-22 14:48     ` Wei Liu
2016-04-22 17:12       ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570BA399.3060100@suse.com \
    --to=jgross@suse.com \
    --cc=cyliu@suse.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.