From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk Date: Mon, 11 Apr 2016 09:49:56 -0400 Message-ID: <570BAB84.903@oracle.com> References: <1460158825-13117-1-git-send-email-mcgrof@kernel.org> <1460158825-13117-5-git-send-email-mcgrof@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1460158825-13117-5-git-send-email-mcgrof@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: "Luis R. Rodriguez" , bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, rusty@rustcorp.com.au Cc: kozerkov@parallels.com, matt@codeblueprint.co.uk, lv.zheng@intel.com, xen-devel@lists.xensource.com, joro@8bytes.org, x86@kernel.org, robert.moore@intel.com, linux-acpi@vger.kernel.org, glin@suse.com, lenb@kernel.org, josh@joshtriplett.org, jlee@suse.com, lguest@lists.ozlabs.org, andriy.shevchenko@linux.intel.com, toshi.kani@hp.com, andrew.cooper3@citrix.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, luto@amacapital.net, david.vrabel@citrix.com, tiwai@suse.de List-Id: linux-acpi@vger.kernel.org T24gMDQvMDgvMjAxNiAwNzo0MCBQTSwgTHVpcyBSLiBSb2RyaWd1ZXogd3JvdGU6CgpkaWZmIC0t Z2l0IGEvYXJjaC94ODYvaW5jbHVkZS9hc20veDg2X2luaXQuaCBiL2FyY2gveDg2L2luY2x1ZGUv YXNtL3g4Nl9pbml0LmgKaW5kZXggMWFlODlhMjcyMWQ2Li44YmI4YzFhNDYxNWEgMTAwNjQ0Ci0t LSBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3g4Nl9pbml0LmgKKysrIGIvYXJjaC94ODYvaW5jbHVk ZS9hc20veDg2X2luaXQuaApAQCAtMTQyLDYgKzE0MiwxNSBAQCBzdHJ1Y3QgeDg2X2NwdWluaXRf b3BzIHsKICBzdHJ1Y3QgdGltZXNwZWM7CiAgCiAgLyoqCisgKiBzdHJ1Y3QgeDg2X2xlZ2FjeV9m ZWF0dXJlcyAtIGxlZ2FjeSB4ODYgZmVhdHVyZXMKKyAqCisgKiBAcnRjOiB0aGlzIGRldmljZSBo YXMgYSBDTU9TIHJlYWwtdGltZSBjbG9jayBwcmVzZW50CisgKi8KK3N0cnVjdCB4ODZfbGVnYWN5 X2ZlYXR1cmVzIHsKKwlpbnQgcnRjOworfTsKKworLyoqCiAgICogc3RydWN0IHg4Nl9wbGF0Zm9y bV9vcHMgLSBwbGF0Zm9ybSBzcGVjaWZpYyBydW50aW1lIGZ1bmN0aW9ucwogICAqIEBjYWxpYnJh dGVfdHNjOgkJY2FsaWJyYXRlIFRTQwogICAqIEBnZXRfd2FsbGNsb2NrOgkJZ2V0IHRpbWUgZnJv bSBIVyBjbG9jayBsaWtlIFJUQyBldGMuCkBAIC0xNTIsNiArMTYxLDE0IEBAIHN0cnVjdCB0aW1l c3BlYzsKICAgKiBAc2F2ZV9zY2hlZF9jbG9ja19zdGF0ZToJc2F2ZSBzdGF0ZSBmb3Igc2NoZWRf Y2xvY2soKSBvbiBzdXNwZW5kCiAgICogQHJlc3RvcmVfc2NoZWRfY2xvY2tfc3RhdGU6CXJlc3Rv cmUgc3RhdGUgZm9yIHNjaGVkX2Nsb2NrKCkgb24gcmVzdW1lCiAgICogQGFwaWNfcG9zdF9pbml0 OgkJYWRqdXN0IGFwaWMgaWYgbmVlZWRlZAorICogQGxlZ2FjeToJCQlsZWdhY3kgZmVhdHVyZXMK KyAqIEBzZXRfbGVnYWN5X2ZlYXR1cmVzOglvdmVycmlkZSBsZWdhY3kgZmVhdHVyZXMuIFVzZSBv ZiB0aGlzIGNhbGxiYWNrCisgKiAJCQkJaXMgaGlnaGx5IGRpc2NvdXJhZ2VkLiBZb3Ugc2hvdWxk IG9ubHkgbmVlZAorICogCQkJCXRoaXMgaWYgeW91ciBoYXJkd2FyZSBwbGF0Zm9ybSByZXF1aXJl cyBmdXJ0aGVyCisgKiAJCQkJY3VzdG9tIGZpbmUgdHVuaW5nIGZhciBiZXlvbmcgd2hhdCBtYXkg YmUKKyAqIAkJCQlwb3NzaWJsZSBpbiB4ODZfZWFybHlfaW5pdF9wbGF0Zm9ybV9xdWlya3MoKSBi eQorICogCQkJCW9ubHkgdXNpbmcgdGhlIGN1cnJlbnQgeDg2X2hhcmR3YXJlX3N1YmFyY2gKKyAq IAkJCQlzZW1hbnRpY3MuCiAgICovCiAgc3RydWN0IHg4Nl9wbGF0Zm9ybV9vcHMgewogIAl1bnNp Z25lZCBsb25nICgqY2FsaWJyYXRlX3RzYykodm9pZCk7CkBAIC0xNjUsNiArMTgyLDggQEAgc3Ry dWN0IHg4Nl9wbGF0Zm9ybV9vcHMgewogIAl2b2lkICgqc2F2ZV9zY2hlZF9jbG9ja19zdGF0ZSko dm9pZCk7CiAgCXZvaWQgKCpyZXN0b3JlX3NjaGVkX2Nsb2NrX3N0YXRlKSh2b2lkKTsKICAJdm9p ZCAoKmFwaWNfcG9zdF9pbml0KSh2b2lkKTsKKwlzdHJ1Y3QgeDg2X2xlZ2FjeV9mZWF0dXJlcyBs ZWdhY3k7CgoKSSBkb24ndCB0aGluayB0aGlzIGJlbG9uZ3MgaGVyZSAtLS0gd2UgYXJlIGluIHRo ZSBvcHMgc3RydWN0dXJlLgoKLWJvcmlzCgo+ICsJdm9pZCAoKnNldF9sZWdhY3lfZmVhdHVyZXMp KHZvaWQpOwo+ICAgfTsKPiAgIAo+ICAgc3RydWN0IHBjaV9kZXY7Cj4gQEAgLTE4Niw2ICsyMDUs OCBAQCBleHRlcm4gc3RydWN0IHg4Nl9jcHVpbml0X29wcyB4ODZfY3B1aW5pdDsKPiAgIGV4dGVy biBzdHJ1Y3QgeDg2X3BsYXRmb3JtX29wcyB4ODZfcGxhdGZvcm07Cj4gICBleHRlcm4gc3RydWN0 IHg4Nl9tc2lfb3BzIHg4Nl9tc2k7Cj4gICBleHRlcm4gc3RydWN0IHg4Nl9pb19hcGljX29wcyB4 ODZfaW9fYXBpY19vcHM7Cj4gKwo+ICtleHRlcm4gdm9pZCB4ODZfZWFybHlfaW5pdF9wbGF0Zm9y bV9xdWlya3Modm9pZCk7Cj4gICBleHRlcm4gdm9pZCB4ODZfaW5pdF9ub29wKHZvaWQpOwo+ICAg ZXh0ZXJuIHZvaWQgeDg2X2luaXRfdWludF9ub29wKHVuc2lnbmVkIGludCB1bnVzZWQpOwo+ICAg Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54 ZW4ub3JnL3hlbi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933336AbcDKN4A (ORCPT ); Mon, 11 Apr 2016 09:56:00 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41796 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933488AbcDKNwN (ORCPT ); Mon, 11 Apr 2016 09:52:13 -0400 Subject: Re: [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk To: "Luis R. Rodriguez" , bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, rusty@rustcorp.com.au References: <1460158825-13117-1-git-send-email-mcgrof@kernel.org> <1460158825-13117-5-git-send-email-mcgrof@kernel.org> Cc: x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, david.vrabel@citrix.com, konrad.wilk@oracle.com, xen-devel@lists.xensource.com, lguest@lists.ozlabs.org, andriy.shevchenko@linux.intel.com, jlee@suse.com, glin@suse.com, matt@codeblueprint.co.uk, andrew.cooper3@citrix.com, rjw@rjwysocki.net, lenb@kernel.org, robert.moore@intel.com, lv.zheng@intel.com, toshi.kani@hp.com, linux-acpi@vger.kernel.org, kozerkov@parallels.com, josh@joshtriplett.org, joro@8bytes.org, tiwai@suse.de From: Boris Ostrovsky Message-ID: <570BAB84.903@oracle.com> Date: Mon, 11 Apr 2016 09:49:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1460158825-13117-5-git-send-email-mcgrof@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2016 07:40 PM, Luis R. Rodriguez wrote: diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 1ae89a2721d6..8bb8c1a4615a 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -142,6 +142,15 @@ struct x86_cpuinit_ops { struct timespec; /** + * struct x86_legacy_features - legacy x86 features + * + * @rtc: this device has a CMOS real-time clock present + */ +struct x86_legacy_features { + int rtc; +}; + +/** * struct x86_platform_ops - platform specific runtime functions * @calibrate_tsc: calibrate TSC * @get_wallclock: get time from HW clock like RTC etc. @@ -152,6 +161,14 @@ struct timespec; * @save_sched_clock_state: save state for sched_clock() on suspend * @restore_sched_clock_state: restore state for sched_clock() on resume * @apic_post_init: adjust apic if neeeded + * @legacy: legacy features + * @set_legacy_features: override legacy features. Use of this callback + * is highly discouraged. You should only need + * this if your hardware platform requires further + * custom fine tuning far beyong what may be + * possible in x86_early_init_platform_quirks() by + * only using the current x86_hardware_subarch + * semantics. */ struct x86_platform_ops { unsigned long (*calibrate_tsc)(void); @@ -165,6 +182,8 @@ struct x86_platform_ops { void (*save_sched_clock_state)(void); void (*restore_sched_clock_state)(void); void (*apic_post_init)(void); + struct x86_legacy_features legacy; I don't think this belongs here --- we are in the ops structure. -boris > + void (*set_legacy_features)(void); > }; > > struct pci_dev; > @@ -186,6 +205,8 @@ extern struct x86_cpuinit_ops x86_cpuinit; > extern struct x86_platform_ops x86_platform; > extern struct x86_msi_ops x86_msi; > extern struct x86_io_apic_ops x86_io_apic_ops; > + > +extern void x86_early_init_platform_quirks(void); > extern void x86_init_noop(void); > extern void x86_init_uint_noop(unsigned int unused); > >