From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ape0h-00009o-A7 for qemu-devel@nongnu.org; Mon, 11 Apr 2016 11:44:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ape0c-0006QW-AV for qemu-devel@nongnu.org; Mon, 11 Apr 2016 11:44:19 -0400 Received: from mail-db3on0105.outbound.protection.outlook.com ([157.55.234.105]:41413 helo=emea01-db3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ape0b-0006QO-Pn for qemu-devel@nongnu.org; Mon, 11 Apr 2016 11:44:14 -0400 References: <1459924806-306-1-git-send-email-den@openvz.org> From: "Denis V. Lunev" Message-ID: <570BB0B3.1090206@openvz.org> Date: Mon, 11 Apr 2016 17:12:03 +0300 MIME-Version: 1.0 In-Reply-To: <1459924806-306-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for 2.6 v4 0/3] ide: fix loss of the dma/atapi state during migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Pavel Butsykin , John Snow On 04/06/2016 09:40 AM, Denis V. Lunev wrote: > This patch set fixes bugs in the IDE DMA and the IDE ATAPI on operations = to > save/restore the state. > > From the user point of view this results in IDE timeouts in the guest > when the user reads from the DVD like the following: > > [424332.169229] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6= frozen > [424332.170423] sr 0:0:0:0: [sr0] CDB: > [424332.171234] Read(10): 28 00 00 00 02 e4 00 00 01 00 > [424332.172418] ata1.00: cmd a0/01:00:00:00:08/00:00:00:00:00/a0 tag 0 dm= a 2048 in > res 40/00:02:00:0c:00/00:00:00:00:00/a0 Emask 0x4 (timeout) > [424332.174877] ata1.00: status: { DRDY } > [424337.212099] ata1: link is slow to respond, please be patient (ready= =3D0) > [424342.220084] ata1: device not ready (errno=3D-16), forcing hardreset > [424342.222700] ata1: soft resetting link > [424342.381059] ata1.00: configured for MWDMA2 > [424342.383693] ata1: EH complete > > Another similar nasty effects are possible. > > Signed-off-by: Pavel Butsykin > Reviewed-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: John Snow > > Changes from v1: > - added converter of IDE_DMA_* to IDE_RETRY_* (1) > - fixed handling of the IDE_RETRY_HBA at the ide_restart_bh function (3) > > Changes from v2: > - fixed enumeration value =E2=80=98IDE_DMA_ATAPI=E2=80=99 not handled in = switch for macio.c (3) > > Changes from v3: > - move the IDE_DMA_ATAPI setting in the cmd_packet func (3) > > Pavel Butsykin (3): > ide: don't lose pending dma state > ide: restart atapi dma by re-evaluating command packet > ide: really restart pending and in-flight atapi dma > > hw/ide/atapi.c | 26 ++++++++++++-------------- > hw/ide/core.c | 39 ++++++++++++++++----------------------- > hw/ide/internal.h | 36 ++++++++++++++++++++++++++++++++++++ > hw/ide/macio.c | 2 ++ > hw/ide/pci.c | 4 ++++ > 5 files changed, 70 insertions(+), 37 deletions(-) > ping