All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org,
	Martin Tarenskeen <m.tarenskeen@zonnet.nl>
Subject: Re: [PATCH 1/2] amidi: ignore not only Active Sensing	but all System Real-Time messages
Date: Mon, 11 Apr 2016 16:13:08 +0200	[thread overview]
Message-ID: <570BB0F4.2020504@ladisch.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1604111535500.9999@lnxricardw1.se.axis.com>

Ricard Wanderlof wrote:
> On Mon, 11 Apr 2016, Clemens Ladisch wrote:
>> Ricard Wanderlof wrote:
>>> I would argue that it would be better to have both options, somehow. I.e.
>>> active sensing is mostly a nuisance, but I can imagine occasions
>>> (analyzing the output from a sequencer perhaps) where one would want to
>>> keep the rest of the real time messages.
>>
>> I can imagine this too, and even more complex filters.
>>
>> But the amidi tool is designed to be simple, and works on the lowest
>> level, with raw MIDI bytes.  This makes it appropriate to handle SysEx
>> stuff and to debug low-level hardware problems, but when you care about
>> the semantics of the messages, you should use a higher-level tool, such
>> as aseqdump.
>>
>> Filtering out clock messages serves an actual need.  But I am not
>> willing to add complexity for a problem that is, at the moment, nothing
>> but a figment of our imaginations.
>
> My argument is really that currently amidi has an option for filtering out
> active sensing, which has probably been added as it serves a useful
> purpose in its own right. The patch replaces that filter with one that
> filters out everything from F8 (clock) and up

I consider this change a bug fix; I just forgot about clock messages
when I originally impemented the filter.

> I think it would be better to keep the existing option, and add a new
> one, rather than to essentially change the meaning of the existing
> option.

That would be a new feature.


Regards,
Clemens

  reply	other threads:[~2016-04-11 14:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-10 19:29 [PATCH 1/2] amidi: ignore not only Active Sensing but all System Real-Time messages Clemens Ladisch
2016-04-10 19:30 ` [PATCH 2/2] amidi: fix timeout handling Clemens Ladisch
2016-04-11  7:00 ` [PATCH 1/2] amidi: ignore not only Active Sensing but all System Real-Time messages Ricard Wanderlof
2016-04-11 11:17   ` Martin Tarenskeen
2016-04-11 11:47     ` Martin Tarenskeen
2016-04-11 13:29   ` Clemens Ladisch
2016-04-11 13:41     ` Ricard Wanderlof
2016-04-11 14:13       ` Clemens Ladisch [this message]
2016-04-11 14:18         ` Ricard Wanderlof
2016-04-17 13:21   ` [PATCH v2 1/2] amidi: ignore not only Active Sensing but also Clock bytes Clemens Ladisch
2016-04-17 13:21     ` [PATCH v2 2/2] amidi: fix timeout handling Clemens Ladisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570BB0F4.2020504@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=m.tarenskeen@zonnet.nl \
    --cc=ricard.wanderlof@axis.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.