From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?THVrw6HFoSBEb2t0b3I=?= Subject: Re: [PATCH 2/2] powerpc: Improve "kvm unavailable" message Date: Mon, 11 Apr 2016 16:50:02 +0200 Message-ID: <570BB99A.4010406@redhat.com> References: <1460374673-12492-1-git-send-email-ldoktor@redhat.com> <1460374673-12492-3-git-send-email-ldoktor@redhat.com> <20160411120204.yxi2bdxalaybcbop@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, pbonzini@redhat.com, lvivier@redhat.com, rkrcmar@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47060 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbcDKOuH (ORCPT ); Mon, 11 Apr 2016 10:50:07 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9DE6C04B302 for ; Mon, 11 Apr 2016 14:50:05 +0000 (UTC) In-Reply-To: <20160411120204.yxi2bdxalaybcbop@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Dne 11.4.2016 v 14:02 Andrew Jones napsal(a): > On Mon, Apr 11, 2016 at 01:37:53PM +0200, Luk=C3=A1=C5=A1 Doktor wrot= e: >> The message when ACCEL=3Dkvm and kvm not available is rather confusi= ng. >> Let's produce (hopefully) easier to understand message. >> >> Signed-off-by: Luk=C3=A1=C5=A1 Doktor >> --- >> powerpc/run | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/powerpc/run b/powerpc/run >> index 56698e6..adffb93 100755 >> --- a/powerpc/run >> +++ b/powerpc/run >> @@ -16,7 +16,7 @@ if [ -c /dev/kvm ]; then >> fi >> >> if [ "$ACCEL" =3D "kvm" ] && [ "$kvm_available" !=3D "yes" ]; then >> - echo "skip $TESTNAME (kvm only)" >> + echo "skip $TESTNAME (kvm not available on your system)" > > This will now be inconsistent with scripts/runtime.bash. Also, > the 'kvm only' message conveys that this test can only run with > kvm, as opposed to also with tcg. While I agree it's terse, we've > now lost that information with the new message. Additionally, I > would say 'this system' instead of 'your system' in the message. > > I think Radim has some plans for giving run script error messages > an overhaul. Maybe he can address this one with that series too? > Anyway, for now, I would suggest we drop this patch. > I thought the message probably has some inner-context, but for me it wa= s=20 super confusing. Even more because I'm using ACCEL=3Dkvm,kvm-type=3DPR ... in some of my power testing, which works well, but when I tried ACCEL=3Dkvm ... it reported test skips. I'm looking forward to some proper errors=20 handling (and ways to pass SKIPs as well). Thank you and feel free to drop this patch, Luk=C3=A1=C5=A1 > Thanks, > drew > >> exit 2 >> fi >> >> -- >> 2.5.5 >>