All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org
Cc: tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com
Subject: Please ignore this (was: Re: [PATCH RFC 03/11] drm/tilcdc: Initialize dummy plane from crtc init)
Date: Mon, 11 Apr 2016 19:51:33 +0300	[thread overview]
Message-ID: <570BD615.8040201@ti.com> (raw)
In-Reply-To: <469c3995bd4960156eeb892b1fb0a0028083c47f.1460378231.git.jsarha@ti.com>

Please ignore this.

BR,
Jyri

On 04/11/16 19:46, Jyri Sarha wrote:
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> index 78466ed..6b39be7 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> @@ -26,6 +26,7 @@
>  struct tilcdc_crtc {
>  	struct drm_crtc base;
>  
> +	struct drm_plane primary;
>  	const struct tilcdc_panel_info *info;
>  	struct drm_pending_vblank_event *event;
>  	int dpms;
> @@ -162,7 +163,6 @@ static void tilcdc_crtc_destroy(struct drm_crtc *crtc)
>  	struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc);
>  
>  	tilcdc_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
> -
>  	of_node_put(crtc->port);
>  	drm_crtc_cleanup(crtc);
>  	drm_flip_work_cleanup(&tilcdc_crtc->unref_work);
> @@ -793,6 +793,10 @@ struct drm_crtc *tilcdc_crtc_create(struct drm_device *dev)
>  
>  	crtc = &tilcdc_crtc->base;
>  
> +	ret = tilcdc_plane_init(dev, &tilcdc_crtc->primary);
> +	if (ret < 0)
> +		goto fail;
> +
>  	tilcdc_crtc->dpms = DRM_MODE_DPMS_OFF;
>  	init_waitqueue_head(&tilcdc_crtc->frame_done_wq);
>  
> @@ -802,7 +806,11 @@ struct drm_crtc *tilcdc_crtc_create(struct drm_device *dev)
>  	spin_lock_init(&tilcdc_crtc->irq_lock);
>  	INIT_WORK(&tilcdc_crtc->recover_work, tilcdc_crtc_recover_work);
>  
> -	ret = drm_crtc_init(dev, crtc, &tilcdc_crtc_funcs);
> +	ret = drm_crtc_init_with_planes(dev, crtc,
> +					&tilcdc_crtc->primary,
> +					NULL,
> +					&tilcdc_crtc_funcs,
> +					"tilcdc crtc");
>  	if (ret < 0)
>  		goto fail;
>  
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2016-04-11 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1460378231.git.jsarha@ti.com>
2016-04-11 16:46 ` [PATCH RFC 03/11] drm/tilcdc: Initialize dummy plane from crtc init Jyri Sarha
2016-04-11 16:51   ` Jyri Sarha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570BD615.8040201@ti.com \
    --to=jsarha@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.