From: Oleksij Rempel <linux@rempel-privat.de>
To: Gustav Frederiksen <lkml2017@openmailbox.org>,
Julian Calaby <julian.calaby@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] Revert regression in ath9k on AR9281
Date: Mon, 11 Apr 2016 21:04:55 +0200 [thread overview]
Message-ID: <570BF557.40705@rempel-privat.de> (raw)
In-Reply-To: <6567cc33c0ca681364c6510a7797c459@openmailbox.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 271 bytes --]
Hi Gustav,
thank you for your work.
Can you please test attached patch.
Am 11.04.2016 um 04:28 schrieb Gustav Frederiksen:
> Hi,
> thank you for taking the time to answer my previous email and for
> providing those useful tips.
....
--
Regards,
Oleksij
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: ath_fix.patch --]
[-- Type: text/x-patch; name="ath_fix.patch", Size: 1623 bytes --]
diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c
index 8f87930..1b271b9 100644
--- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c
@@ -274,6 +274,9 @@ void ar5008_hw_cmn_spur_mitigate(struct ath_hw *ah,
};
static const int inc[4] = { 0, 100, 0, 0 };
+ memset(&mask_m, 0, sizeof(int8_t) * 123);
+ memset(&mask_p, 0, sizeof(int8_t) * 123);
+
cur_bin = -6000;
upper = bin + 100;
lower = bin - 100;
@@ -424,14 +427,9 @@ static void ar5008_hw_spur_mitigate(struct ath_hw *ah,
int tmp, new;
int i;
- int8_t mask_m[123];
- int8_t mask_p[123];
int cur_bb_spur;
bool is2GHz = IS_CHAN_2GHZ(chan);
- memset(&mask_m, 0, sizeof(int8_t) * 123);
- memset(&mask_p, 0, sizeof(int8_t) * 123);
-
for (i = 0; i < AR_EEPROM_MODAL_SPURS; i++) {
cur_bb_spur = ah->eep_ops->get_spur_channel(ah, i, is2GHz);
if (AR_NO_SPUR == cur_bb_spur)
diff --git a/drivers/net/wireless/ath/ath9k/ar9002_phy.c b/drivers/net/wireless/ath/ath9k/ar9002_phy.c
index db66245..53d7445 100644
--- a/drivers/net/wireless/ath/ath9k/ar9002_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar9002_phy.c
@@ -178,14 +178,9 @@ static void ar9002_hw_spur_mitigate(struct ath_hw *ah,
int i;
struct chan_centers centers;
- int8_t mask_m[123];
- int8_t mask_p[123];
int cur_bb_spur;
bool is2GHz = IS_CHAN_2GHZ(chan);
- memset(&mask_m, 0, sizeof(int8_t) * 123);
- memset(&mask_p, 0, sizeof(int8_t) * 123);
-
ath9k_hw_get_channel_centers(ah, chan, ¢ers);
freq = centers.synth_center;
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2016-04-11 19:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 22:24 [PATCH] Revert regression in ath9k on AR9281 lkml2017
2016-04-08 0:53 ` Julian Calaby
2016-04-11 2:28 ` Gustav Frederiksen
2016-04-11 19:04 ` Oleksij Rempel [this message]
2016-04-12 1:53 ` Gustav Frederiksen
2016-04-12 17:37 ` [ath9k-devel] [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation Oleksij Rempel
2016-04-12 17:37 ` Oleksij Rempel
2016-04-13 9:41 ` [ath9k-devel] " Kalle Valo
2016-04-13 9:41 ` Kalle Valo
2016-04-13 9:45 ` [ath9k-devel] " Kalle Valo
2016-04-13 9:45 ` Kalle Valo
2016-04-13 16:45 ` [ath9k-devel] " Oleksij Rempel
2016-04-13 16:45 ` Oleksij Rempel
2016-04-15 18:05 ` ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_pinitialisation Kalle Valo
2016-04-15 18:05 ` [ath9k-devel] " Kalle Valo
2016-04-15 20:59 ` [ath9k-devel] [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation Bob Copeland
2016-04-15 20:59 ` Bob Copeland
2016-04-16 6:01 ` [ath9k-devel] " Oleksij Rempel
2016-04-16 6:01 ` Oleksij Rempel
2016-04-16 14:53 ` [ath9k-devel] " Bob Copeland
2016-04-16 14:53 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BF557.40705@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lkml2017@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.