From: gpiccoli@linux.vnet.ibm.com (Guilherme G. Piccoli)
Subject: [PATCH 1/2] nvme: Fix pci_device_id table by adding the most generic devices in the end
Date: Mon, 11 Apr 2016 17:57:19 -0300 [thread overview]
Message-ID: <570C0FAF.6030000@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160411204823.GL2781@linux.intel.com>
On 04/11/2016 05:48 PM, Matthew Wilcox wrote:
> On Mon, Apr 11, 2016@05:15:50PM -0300, Guilherme G. Piccoli wrote:
>> The struct pci_device_id is used on a PCI driver probe by the PCI core
>> mechanism to match the devices present on the system with the driver
>> being probed. For each device, the match procedure reads each entry in
>> the pci_device_id struct provided by the driver and tries to match the
>> first entry it is able to do.
>
> What you're missing is that the Apple device doesn't have the NVMe
> programming model / class code. So this patch actually has no effect.
>
Oh, okay. Thanks for pointing this. I imagined that it would be possible
that this Apple device does not have NVMe class code (or it would been a
mistake have added the entry after the PCI_DEVICE_CLASS() in that table).
Anyway, my choice was to send the patch and take the shot. Do you want
me to re-send the 2nd part of this patch alone, as v2?
Cheers,
Guilherme
prev parent reply other threads:[~2016-04-11 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 20:15 [PATCH 1/2] nvme: Fix pci_device_id table by adding the most generic devices in the end Guilherme G. Piccoli
2016-04-11 20:15 ` [PATCH 2/2] nvme/quirk: Add a delay before checking for adapter readiness Guilherme G. Piccoli
2016-04-12 17:56 ` Jeff Lien
[not found] ` <201604121948.u3CJmrdR002584@d03av01.boulder.ibm.com>
2016-04-12 20:02 ` Keith Busch
2016-04-12 20:13 ` Guilherme G. Piccoli
2016-04-12 17:58 ` David Darrington
2016-04-12 20:12 ` Guilherme G. Piccoli
2016-04-12 20:31 ` David Darrington
2016-04-11 20:48 ` [PATCH 1/2] nvme: Fix pci_device_id table by adding the most generic devices in the end Matthew Wilcox
2016-04-11 20:57 ` Guilherme G. Piccoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570C0FAF.6030000@linux.vnet.ibm.com \
--to=gpiccoli@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.