From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755173AbcDKWnM (ORCPT ); Mon, 11 Apr 2016 18:43:12 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:41457 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755047AbcDKWnJ (ORCPT ); Mon, 11 Apr 2016 18:43:09 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79d96d0000012b1-5f-570c287a2eeb Content-transfer-encoding: 8BIT Message-id: <570C287A.8040002@samsung.com> Date: Tue, 12 Apr 2016 07:43:06 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Roger Quadros , myungjoo.ham@samsung.com Cc: linux-kernel@vger.kernel.org, Grygorii Strashko Subject: Re: [PATCH v3] extcon: usb-gpio: Don't miss event during suspend/resume References: <1459951299-20578-1-git-send-email-rogerq@ti.com> <57075F23.8080703@ti.com> <570BAEFD.2050406@ti.com> In-reply-to: <570BAEFD.2050406@ti.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42JZI2JSolulwRNu8GGFssXKKSwWl3fNYbO4 3biCzaLnkZYDi0ffllWMHsdvbGfy+LxJLoA5issmJTUnsyy1SN8ugStj5d82toL9HBWXjmxh bmB8wdbFyMkhIWAicWfdPSYIW0ziwr31QHEuDiGBFYwSM3dfYocpevD7EiNEYimjRMPxhcwg CV4BQYkfk++xdDFycDALyEscuZQNEmYWUJeYNG8RM0T9A0aJpVsb2CDqtSTen1wDto1FQFWi f+deVhCbDSi+/8UNNpA5ogIREt0nKkFMEQFriQ3ffSCm+0ncnigHUiwsECDx8coUsEYhgWKJ 1d1XwK7kFFCTOHb2FgvIVgmBdewSD+dPYIHYJCDxbfIhsCslBGQlNh1ghvhKUuLgihssExjF ZiH5ZRbCL7OQ/LKAkXkVo2hqQXJBcVJ6kZFecWJucWleul5yfu4mRmDknP73rG8H480D1ocY BTgYlXh4Ha5xhQuxJpYVV+YeYjQFOmIis5Rocj4wPvNK4g2NzYwsTE1MjY3MLc2UxHkTpH4G CwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamAUjVvloemhUKO9sSTK+Ino2u/8Je26t1tapa4y GebLvt20ma/7mkKtYFFWfdHNZIWIHSriaYsFXt0yXyEo5O3x7sTB/b63q5XOZd+KD1Bcpe62 sOBx+hWhCdlrLq0pWPHl2r4DIS1V+4/9D1z1eyrrHY/ZPT8sxFrU7pkEuE7bPe0qj9Qes19K LMUZiYZazEXFiQC3mleFlwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsVy+t9jAd0qDZ5wg2sLZCxWTmGxuLxrDpvF 7cYVbBY9j7QcWDz6tqxi9Dh+YzuTx+dNcgHMUQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGm ZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAy5QUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYE wfUYGaCBhDWMGSv/trEV7OeouHRkC3MD4wu2LkZODgkBE4kHvy8xQthiEhfurQeKc3EICSxl lGg4vpAZJMErICjxY/I9li5GDg5mAXmJI5eyQcLMAuoSk+YtYoaof8AosXRrAxtEvZbE+5Nr mEBsFgFVif6de1lBbDag+P4XN9hA5ogKREh0n6gEMUUErCU2fPeBmO4ncXuiHEixsECAxMcr U8AahQSKJVZ3X2EHsTkF1CSOnb3FMoFRYBaS22Yh3DYLyW0LGJlXMUqkFiQXFCel5xrmpZbr FSfmFpfmpesl5+duYgRH5zOpHYwHd7kfYhTgYFTi4X1xmStciDWxrLgy9xCjBAezkgivvSpP uBBvSmJlVWpRfnxRaU5q8SFGU6DnJjJLiSbnAxNHXkm8obGJmZGlkbmhhZGxuZI47+P/68KE BNITS1KzU1MLUotg+pg4OKUaGOftvuGwNqXzQOcE33nz3gedvcf/7+S2vn06EvWNj9T0ft38 +LaxOSv/Q9XjdUuqbSuOnk18o2WhXNIza+WussjGg33dVT9E2x1uxVsX3OQLOqb51flcxuyO H1tP/CsPlUnj2BvLcCB3+ao3tmwmb8pPLLRRF5Bf8+mwdN+F49p3/E4sq6tl01ZiKc5INNRi LipOBADjn3hm5AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, On 2016년 04월 11일 23:04, Roger Quadros wrote: > Pin state might have changed during suspend/resume while > our interrupts were disabled and if device doesn't support wakeup. > > Scan for change during resume for such case. > > Signed-off-by: Roger Quadros > --- > v3: > - use queue_delayed_work() instead of directly calling usb_extcon_detect_cable() > > v2: > - only check for state change during resume if device wakeup is > > drivers/extcon/extcon-usb-gpio.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index bc61d11..bad2159 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -185,6 +185,9 @@ static int usb_extcon_resume(struct device *dev) > int ret = 0; > > enable_irq(info->id_irq); > + if (!device_may_wakeup(dev)) > + queue_delayed_work(system_power_efficient_wq, > + &info->wq_detcable, 0); > > return ret; > } > Applied it. Thanks, Chanwoo Choi