From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kefeng Wang Subject: Re: [PATCH v2 1/2] dt/bindings: Add bindings for hisilicon random number generator Date: Tue, 12 Apr 2016 09:16:02 +0800 Message-ID: <570C4C52.4020902@huawei.com> References: <1460017397-30996-1-git-send-email-wangkefeng.wang@huawei.com> <1460017397-30996-2-git-send-email-wangkefeng.wang@huawei.com> <20160411144306.GA24637@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , Mark Rutland , , Herbert Xu , To: Rob Herring Return-path: In-Reply-To: <20160411144306.GA24637@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On 2016/4/11 22:43, Rob Herring wrote: > On Thu, Apr 07, 2016 at 04:23:16PM +0800, Kefeng Wang wrote: >> Document the devicetree bindings for the random number generator found >> on Hisilicon Hip04 and Hip05 soc. >> >> Signed-off-by: Kefeng Wang >> --- >> Documentation/devicetree/bindings/rng/hisi-rng.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rng/hisi-rng.txt >> >> diff --git a/Documentation/devicetree/bindings/rng/hisi-rng.txt b/Documentation/devicetree/bindings/rng/hisi-rng.txt >> new file mode 100644 >> index 0000000..72efcc1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rng/hisi-rng.txt >> @@ -0,0 +1,12 @@ >> +Hisilicon Random Number Generator >> + >> +Required properties: >> +- compatible : Should be "hisilicon,rng" >> +- reg : Offset and length of the register set of this block >> + >> +Example: >> + >> +rng@d1010000 { >> + compatible = "hisilicon,rng"; > > This still needs SoC specific compatible strings. It is used by Hip04/Hip05 at lease, but for new SoC, like Hip06, it maybe different, using single Soc prefix is not proper, how about hisilicon,rng-v1, or add two compatible hisilicon,hip04-rng and hisilicon,hip05-rng? What's your option? Thanks. > >> + reg = <0xd1010000 0x100>; >> +}; >> -- >> 2.6.0.GIT >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangkefeng.wang@huawei.com (Kefeng Wang) Date: Tue, 12 Apr 2016 09:16:02 +0800 Subject: [PATCH v2 1/2] dt/bindings: Add bindings for hisilicon random number generator In-Reply-To: <20160411144306.GA24637@rob-hp-laptop> References: <1460017397-30996-1-git-send-email-wangkefeng.wang@huawei.com> <1460017397-30996-2-git-send-email-wangkefeng.wang@huawei.com> <20160411144306.GA24637@rob-hp-laptop> Message-ID: <570C4C52.4020902@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/4/11 22:43, Rob Herring wrote: > On Thu, Apr 07, 2016 at 04:23:16PM +0800, Kefeng Wang wrote: >> Document the devicetree bindings for the random number generator found >> on Hisilicon Hip04 and Hip05 soc. >> >> Signed-off-by: Kefeng Wang >> --- >> Documentation/devicetree/bindings/rng/hisi-rng.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rng/hisi-rng.txt >> >> diff --git a/Documentation/devicetree/bindings/rng/hisi-rng.txt b/Documentation/devicetree/bindings/rng/hisi-rng.txt >> new file mode 100644 >> index 0000000..72efcc1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rng/hisi-rng.txt >> @@ -0,0 +1,12 @@ >> +Hisilicon Random Number Generator >> + >> +Required properties: >> +- compatible : Should be "hisilicon,rng" >> +- reg : Offset and length of the register set of this block >> + >> +Example: >> + >> +rng at d1010000 { >> + compatible = "hisilicon,rng"; > > This still needs SoC specific compatible strings. It is used by Hip04/Hip05 at lease, but for new SoC, like Hip06, it maybe different, using single Soc prefix is not proper, how about hisilicon,rng-v1, or add two compatible hisilicon,hip04-rng and hisilicon,hip05-rng? What's your option? Thanks. > >> + reg = <0xd1010000 0x100>; >> +}; >> -- >> 2.6.0.GIT >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kefeng Wang Subject: Re: [PATCH v2 1/2] dt/bindings: Add bindings for hisilicon random number generator Date: Tue, 12 Apr 2016 09:16:02 +0800 Message-ID: <570C4C52.4020902@huawei.com> References: <1460017397-30996-1-git-send-email-wangkefeng.wang@huawei.com> <1460017397-30996-2-git-send-email-wangkefeng.wang@huawei.com> <20160411144306.GA24637@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160411144306.GA24637@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, Mark Rutland , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Herbert Xu , guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2016/4/11 22:43, Rob Herring wrote: > On Thu, Apr 07, 2016 at 04:23:16PM +0800, Kefeng Wang wrote: >> Document the devicetree bindings for the random number generator found >> on Hisilicon Hip04 and Hip05 soc. >> >> Signed-off-by: Kefeng Wang >> --- >> Documentation/devicetree/bindings/rng/hisi-rng.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rng/hisi-rng.txt >> >> diff --git a/Documentation/devicetree/bindings/rng/hisi-rng.txt b/Documentation/devicetree/bindings/rng/hisi-rng.txt >> new file mode 100644 >> index 0000000..72efcc1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rng/hisi-rng.txt >> @@ -0,0 +1,12 @@ >> +Hisilicon Random Number Generator >> + >> +Required properties: >> +- compatible : Should be "hisilicon,rng" >> +- reg : Offset and length of the register set of this block >> + >> +Example: >> + >> +rng@d1010000 { >> + compatible = "hisilicon,rng"; > > This still needs SoC specific compatible strings. It is used by Hip04/Hip05 at lease, but for new SoC, like Hip06, it maybe different, using single Soc prefix is not proper, how about hisilicon,rng-v1, or add two compatible hisilicon,hip04-rng and hisilicon,hip05-rng? What's your option? Thanks. > >> + reg = <0xd1010000 0x100>; >> +}; >> -- >> 2.6.0.GIT >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html