From: Brent Bice <bbice@sgi.com>
To: Alex Lyakas <alex@zadarastorage.com>, xfs@oss.sgi.com
Cc: Shyam Kaushik <shyam@zadarastorage.com>
Subject: Re: [PATCH 4/5] xfs: xfs_inode_free() isn't RCU safe
Date: Tue, 12 Apr 2016 05:29:15 -0600 [thread overview]
Message-ID: <570CDC0B.3070802@sgi.com> (raw)
In-Reply-To: <0A92B65A3BF94F60BB36EA3FA716DF1F@alyakaslap>
Could you resend it to be sure? I flagged it for redelivery the day
I emailed you so if nobody else has seen it yet then something still
didn't work. I was pretty sure I'd seen it get delivered ok to oss,
but... (shrug)
Brent
On 04/12/2016 02:56 AM, Alex Lyakas wrote:
> Hello Dave,
> Looking at the patch, I see that now we call xfs_idestroy_fork() in RCU
> callback. This can do the following chain:
> xfs_iext_destroy => xfs_iext_irec_remove => xfs_iext_realloc_indirect=>
> kmem_realloc => kmem_alloc => kmem_alloc => congestion_wait()
> At least according to documentation, the RCU callback cannot block,
> since it may be called from softirq context. Is this fine?
> Thanks,
> Alex.
> P.S.: I have submitted a patch called “[PATCH] xfs: optimize destruction
> of the indirection array”, which changes xfs_iext_destroy to call only
> kmem_free(). But this patch got stuck in the spam filter of the mailing
> list, and Brent is working to release it from there.
>
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-04-12 11:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 8:56 [PATCH 4/5] xfs: xfs_inode_free() isn't RCU safe Alex Lyakas
2016-04-12 11:29 ` Brent Bice [this message]
2016-04-12 21:11 ` Dave Chinner
2016-04-12 21:55 ` Brent Bice
2016-04-12 23:29 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2016-04-12 8:55 Alex Lyakas
2016-04-06 9:22 [PATCH 0/5] xfs; xfs_iflush_cluster vs xfs_reclaim_inode Dave Chinner
2016-04-06 9:22 ` [PATCH 4/5] xfs: xfs_inode_free() isn't RCU safe Dave Chinner
2016-04-07 15:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570CDC0B.3070802@sgi.com \
--to=bbice@sgi.com \
--cc=alex@zadarastorage.com \
--cc=shyam@zadarastorage.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.