All of lore.kernel.org
 help / color / mirror / Atom feed
From: Crestez Dan Leonard <leonard.crestez@intel.com>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	Daniel Baluta <daniel.baluta@intel.com>
Subject: Re: IIO driver for si114x
Date: Tue, 12 Apr 2016 16:04:39 +0300	[thread overview]
Message-ID: <570CF267.4020804@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1604121404050.4383@pmeerw.net>

On 04/12/2016 03:06 PM, Peter Meerwald-Stadler wrote:
>> I want to add support for a si1145 light sensor. Some brief googling finds a
>> bunch of old (2012) patches for an si114x driver in drivers/iio/light. Here's
>> the link to the old thread:
>>
>> http://comments.gmane.org/gmane.linux.kernel.iio/5478
>
> I have updated sources, not yet posted
> Matt Ranostay also indicated that he'd be willing to work on the device
I found some reasonably recent sources in the chromeos kernel:

https://chromium.googlesource.com/chromiumos/third_party/kernel-next/+/chromeos-4.4/drivers/iio/light/si114x.c

This driver seems to be only for si1141/42/43 models and will explicitly 
fail on probe with the part_id values reported by si1145. Some hacking 
made the driver probe and report some sort of values.

I'm not sure how well that driver is tested, it failed for me at 
register time because SI114X_CURRENT_CHANNEL has the default scan_index 
0 and this is detected as a duplicate despite the fact that scan_type is 
not otherwise filled. This check has been in the IIO core since 3.18.

If you have updated sources can you please post them?

--
Regards,
Leonard

  reply	other threads:[~2016-04-12 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 11:45 IIO driver for si114x Crestez Dan Leonard
2016-04-12 12:06 ` Peter Meerwald-Stadler
2016-04-12 13:04   ` Crestez Dan Leonard [this message]
2016-04-12 13:43     ` Daniel Baluta
2016-04-19 12:42   ` Daniel Baluta
2016-04-20  3:16     ` Matt Ranostay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570CF267.4020804@intel.com \
    --to=leonard.crestez@intel.com \
    --cc=daniel.baluta@intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.