From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 Date: Tue, 12 Apr 2016 16:05:58 +0200 Message-ID: <570D00C6.9000203@samsung.com> References: <1460465378-23486-1-git-send-email-alim.akhtar@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1460465378-23486-1-git-send-email-alim.akhtar@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Alim Akhtar , linux-arm-kernel@lists.infradead.org Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, thomas.ab@samsung.com List-Id: linux-samsung-soc@vger.kernel.org On 04/12/2016 02:49 PM, Alim Akhtar wrote: > This patch adds device tree nodes for pdma0 and pdma1 controllers > found on exynos7 SoCs. > > Signed-off-by: Alim Akhtar > --- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > I would prefer avoid adding all new stuff at the end because it is conflict-prone. Alphabetical order or by address... but none of these are used currently. How about putting it after 'gic' node? Anyway the code looks fine: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Tue, 12 Apr 2016 16:05:58 +0200 Subject: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 In-Reply-To: <1460465378-23486-1-git-send-email-alim.akhtar@samsung.com> References: <1460465378-23486-1-git-send-email-alim.akhtar@samsung.com> Message-ID: <570D00C6.9000203@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/12/2016 02:49 PM, Alim Akhtar wrote: > This patch adds device tree nodes for pdma0 and pdma1 controllers > found on exynos7 SoCs. > > Signed-off-by: Alim Akhtar > --- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > I would prefer avoid adding all new stuff at the end because it is conflict-prone. Alphabetical order or by address... but none of these are used currently. How about putting it after 'gic' node? Anyway the code looks fine: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof