From: Julien Grall <julien.grall@arm.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>, xen-devel@lists.xen.org
Cc: kevin.tian@intel.com, tamas@tklengyel.com, wei.liu2@citrix.com,
jun.nakajima@intel.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, sstabellini@kernel.org,
jbeulich@suse.com, keir@xen.org
Subject: Re: [PATCH] vm_event: Allow subscribing to write events for specific MSR-s
Date: Tue, 12 Apr 2016 15:42:11 +0100 [thread overview]
Message-ID: <570D0943.4060404@arm.com> (raw)
In-Reply-To: <1460471669-3434-1-git-send-email-rcojocaru@bitdefender.com>
Hello Razvan,
On 12/04/2016 15:34, Razvan Cojocaru wrote:
> Previously, subscribing to MSR write events was an all-or-none
> approach, with special cases for introspection MSR-s. This patch
> allows the vm_event consumer to specify exactly what MSR-s it is
> interested in, and as a side-effect gets rid of the
> vmx_introspection_force_enabled_msrs[] special case.
> This replaces the previously posted "xen: Filter out MSR write
> events" patch.
>
> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
> ---
> tools/libxc/include/xenctrl.h | 4 +--
> tools/libxc/xc_monitor.c | 6 ++--
> xen/arch/x86/hvm/event.c | 3 +-
> xen/arch/x86/hvm/hvm.c | 3 +-
> xen/arch/x86/hvm/vmx/vmcs.c | 26 ++--------------
> xen/arch/x86/hvm/vmx/vmx.c | 10 ++----
> xen/arch/x86/monitor.c | 25 +++++++--------
> xen/arch/x86/vm_event.c | 62 ++++++++++++++++++++++++++++++++++++++
> xen/include/asm-arm/vm_event.h | 21 +++++++++++++
Can you explain why you've added stubs for ARM when nobody in the common
code is calling them?
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-12 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 14:34 [PATCH] vm_event: Allow subscribing to write events for specific MSR-s Razvan Cojocaru
2016-04-12 14:42 ` Julien Grall [this message]
2016-04-12 14:45 ` Razvan Cojocaru
2016-04-12 17:49 ` Tamas K Lengyel
2016-04-12 17:57 ` Razvan Cojocaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D0943.4060404@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.