From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq1d1-00009i-RB for qemu-devel@nongnu.org; Tue, 12 Apr 2016 12:57:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aq1d1-0000oH-5B for qemu-devel@nongnu.org; Tue, 12 Apr 2016 12:57:27 -0400 References: <1460472980-26319-1-git-send-email-silbe@linux.vnet.ibm.com> <1460472980-26319-2-git-send-email-silbe@linux.vnet.ibm.com> From: Max Reitz Message-ID: <570D28ED.2050601@redhat.com> Date: Tue, 12 Apr 2016 18:57:17 +0200 MIME-Version: 1.0 In-Reply-To: <1460472980-26319-2-git-send-email-silbe@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PHggUv5jEhi42SscFU9saK8sAMaA5OnEn" Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-iotests: drop unused _within_tolerance() filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sascha Silbe , qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PHggUv5jEhi42SscFU9saK8sAMaA5OnEn Content-Type: multipart/mixed; boundary="OopfJFA7MDTFBaueWlMXn3d19JeChCVou" From: Max Reitz To: Sascha Silbe , qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo Message-ID: <570D28ED.2050601@redhat.com> Subject: Re: [PATCH 1/4] qemu-iotests: drop unused _within_tolerance() filter References: <1460472980-26319-1-git-send-email-silbe@linux.vnet.ibm.com> <1460472980-26319-2-git-send-email-silbe@linux.vnet.ibm.com> In-Reply-To: <1460472980-26319-2-git-send-email-silbe@linux.vnet.ibm.com> --OopfJFA7MDTFBaueWlMXn3d19JeChCVou Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 12.04.2016 16:56, Sascha Silbe wrote: > _within_tolerance() isn't used anymore and possibly creates temporary > files at predictable, world-writable locations. Get rid of it. >=20 > If it's needed again in the future it can be revived easily and fixed u= p > to use TEST_DIR and / or safely created temporary files. >=20 > Signed-off-by: Sascha Silbe > Reviewed-by: Bo Tu > --- > tests/qemu-iotests/common.filter | 101 -------------------------------= -------- > 1 file changed, 101 deletions(-) Reviewed-by: Max Reitz --OopfJFA7MDTFBaueWlMXn3d19JeChCVou-- --PHggUv5jEhi42SscFU9saK8sAMaA5OnEn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXDSjtAAoJEDuxQgLoOKytBikH/jVHaP/UbDOLhaxZ7QeKmIDu 5VWCbstWcKNN5No0JFnkw7t/wS7RZDfj4R0Zz76qRTX+k5Ev1HhnHarHyvU0s24O 3Q13rRWFY83vsPlzT6K25RgqH7x519Le6701D7acZW7jJ1Xu+LGKW2NrDO6hoFCr 28IN+LeOsARqG2uncvuR4KoI5GaTm7iPOYxBNO2eeoR/hZcd/D9giJehqytBI+U9 4z/6Zxn4QDMZFV2YrTB3ePGaI+RTBQdBnLosbB1as1duKG/kJ3jPBl4hdevNvDBC VJidfDNoMtZu/b9mYXCasSkJlQmWLhUaE79A/WWndibLLomt2rZBuaNmnJrj5TU= =vC2W -----END PGP SIGNATURE----- --PHggUv5jEhi42SscFU9saK8sAMaA5OnEn--