Re: [Qemu-devel] [PATCH for-2.6 0/4] qemu-iotests: don't use /tmp

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1223 bytes --]

On 12.04.2016 16:56, Sascha Silbe wrote:
> During review of my other qemu-iotests fixes, Max Reitz noticed a
> couple of additional places where qemu-iotests hardcode /tmp. This is
> both a security issue and cumbersome when running multiple instances
> of qemu-iotests (e.g. different users on a shared development machine
> like tuxmaker). Fix them up.
> 
> Checked (/var)/tmp usage using "sudo chown 000 /tmp /var/tmp". "tac"
> and "qemu -snapshot" fail in that case. I'll presume they create the
> temporary files in a secure manner.
> 
> There is one place left that may use /var/tmp in theory; will address
> that in a separate patch.
> 
> This series mostly removes dead code and addresses a potential
> security issue, all of that in the test suite rather than in
> production code. It should be applicable even during hard freeze.
>  
> 
> Sascha Silbe (4):
>   qemu-iotests: drop unused _within_tolerance() filter
>   qemu-iotests: common.rc: drop unused _do()
>   qemu-iotests: tests: do not set unused tmp variable
>   qemu-iotests: place valgrind log file in scratch dir

Thanks Sascha, I applied the series to my block tree:

https://github.com/XanClic/qemu/commits/block

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]