From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/racehound: fix comment
Date: Wed, 13 Apr 2016 00:04:38 +0200 [thread overview]
Message-ID: <570D70F6.3000404@mind.be> (raw)
In-Reply-To: <87a8kylc6n.fsf@dell.be.48ers.dk>
On 04/13/16 00:00, Peter Korsgaard wrote:
>>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> > racehound requires a kernel >= 3.14 to be built and to run.
> > However, the current conditions on the corresponding comments are wrong:
> > - the comment about the kernel has a dependency on the requested
> > headers
> > - the comment on the toolchain features does not have this condition.
>
> > Thus, the comments are not shown/hidden under the appropriate
> > conditions, like in this situation:
> > - toolchain with headers < 3.14 (e.g. Sourcery CodeBench x86/x86_64
> > 2012.09 with headers 3.5)
> > - kernel 4.5 enabled
>
> > this comment is shown:
> > racehound needs an Linux kernel >= 3.14 to be built
>
> > So, this is incorrect, because:
> > 1- a kernel >= 3.14 is indeed to be built
> > 2- the headers version mismatch is not reported
>
> > Fix that by moving the dependency on the kernel headers to the
> > appropriate comment and enhance it.
>
> > Since there is no way we can know the kernel version to be built, we can
> > not add such a condition; still, we leave the kernel message as-is.
>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Committed, thanks.
So, you don't agree with my analysis? :-)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
prev parent reply other threads:[~2016-04-12 22:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 17:20 [Buildroot] [PATCH] package/racehound: fix comment Yann E. MORIN
2016-04-12 21:27 ` Arnout Vandecappelle
2016-04-12 22:02 ` Peter Korsgaard
2016-04-13 20:18 ` Yann E. MORIN
2016-04-13 20:42 ` Arnout Vandecappelle
2016-04-14 17:09 ` Yann E. MORIN
2016-04-12 22:00 ` Peter Korsgaard
2016-04-12 22:04 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D70F6.3000404@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.