From: axboe@fb.com (Jens Axboe)
Subject: [PATCH v2] nvme: Avoid reset work on watchdog timer function during error recovery
Date: Tue, 12 Apr 2016 23:22:48 -0600 [thread overview]
Message-ID: <570DD7A8.9050607@fb.com> (raw)
In-Reply-To: <1460503929-22613-1-git-send-email-gpiccoli@linux.vnet.ibm.com>
On 04/12/2016 05:32 PM, Guilherme G. Piccoli wrote:
> This patch adds a check on nvme_watchdog_timer() function to avoid the
> call to reset_work() when an error recovery process is ongoing on
> controller. The check is made by looking at pci_channel_offline()
> result.
>
> If we don't check for this on nvme_watchdog_timer(), error recovery
> mechanism can't recover well, because reset_work() won't be able to
> do its job (since we're in the middle of an error) and so the
> controller is removed from the system before error recovery mechanism
> can perform slot reset (which would allow the adapter to recover).
>
> In this patch we also have splitted the huge condition expression in
> nvme_watchdog_timer() by introducing an auxiliary function to help
> make the code more readable.
Added for 4.7, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2016-04-13 5:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 23:32 [PATCH v2] nvme: Avoid reset work on watchdog timer function during error recovery Guilherme G. Piccoli
2016-04-13 5:22 ` Jens Axboe [this message]
2016-04-13 6:03 ` Jens Axboe
2016-04-13 14:12 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570DD7A8.9050607@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.