From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Nutan Shinde <nutanshinde1992@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void
Date: Wed, 13 Apr 2016 09:38:14 +0200 [thread overview]
Message-ID: <570DF766.5020601@redhat.com> (raw)
In-Reply-To: <87potukogq.fsf@dusky.pond.sub.org>
On 13/04/2016 08:33, Markus Armbruster wrote:
> * Look for functions that are named *_exit or *_exitfn in hw/ and that
> return int. They should all return zero. Make them return void, and
> remove the checks for the callers.
... and change the exit method to "void fn(void)"
> * Once the above change is done, remove the "Error **" argument from
> functions named *_unrealize in hw/
... same for the unrealize method.
> Added by Paolo on 2014-12-03. These tasks don't make sense to me.
> Paolo, can you explain?
The exit functions always return zero, the unrealize functions never
touch the Error** argument. So make both of them "void fn(void)" and
remove the difference between exit and unrealize.
Paolo
next prev parent reply other threads:[~2016-04-13 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1460484949-5798-1-git-send-email-nutanshinde1992@gmail.com>
2016-04-12 18:17 ` [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void Nutan Shinde
2016-04-12 21:23 ` Paolo Bonzini
2016-04-13 6:33 ` Markus Armbruster
2016-04-13 7:38 ` Paolo Bonzini [this message]
2016-04-13 11:29 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570DF766.5020601@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=nutanshinde1992@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.