From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Peres Subject: Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings Date: Wed, 13 Apr 2016 10:55:29 +0300 Message-ID: <570DFB71.4070106@free.fr> References: <201604131531.CJokPLHc%fengguang.wu@intel.com> <20160413070742.GA9311@lkp-nex05> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp4-g21.free.fr (smtp4-g21.free.fr [212.27.42.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 762476E876 for ; Wed, 13 Apr 2016 07:55:47 +0000 (UTC) In-Reply-To: <20160413070742.GA9311@lkp-nex05> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: kbuild test robot , Karol Herbst Cc: Ben Skeggs , kbuild-all@01.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMTMvMDQvMTYgMTA6MDcsIGtidWlsZCB0ZXN0IHJvYm90IHdyb3RlOgo+IGRyaXZlcnMvZ3B1 L2RybS9ub3V2ZWF1L252a20vc3ViZGV2L2ljY3NlbnNlL2Jhc2UuYzoxMzM6Mi03OiBXQVJOSU5H OiBOVUxMIGNoZWNrIGJlZm9yZSBmcmVlaW5nIGZ1bmN0aW9ucyBsaWtlIGtmcmVlLCBkZWJ1Z2Zz X3JlbW92ZSwgZGVidWdmc19yZW1vdmVfcmVjdXJzaXZlIG9yIHVzYl9mcmVlX3VyYiBpcyBub3Qg bmVlZGVkLiBNYXliZSBjb25zaWRlciByZW9yZ2FuaXppbmcgcmVsZXZhbnQgY29kZSB0byBhdm9p ZCBwYXNzaW5nIE5VTEwgdmFsdWVzLgo+Cj4gICBOVUxMIGNoZWNrIGJlZm9yZSBzb21lIGZyZWVp bmcgZnVuY3Rpb25zIGlzIG5vdCBuZWVkZWQuCj4KPiAgIEJhc2VkIG9uIGNoZWNrcGF0Y2ggd2Fy bmluZwo+ICAgImtmcmVlKE5VTEwpIGlzIHNhZmUgdGhpcyBjaGVjayBpcyBwcm9iYWJseSBub3Qg cmVxdWlyZWQiCj4gICBhbmQga2ZyZWVhZGRyLmNvY2NpIGJ5IEp1bGlhIExhd2FsbC4KPgo+IEdl bmVyYXRlZCBieTogc2NyaXB0cy9jb2NjaW5lbGxlL2ZyZWUvaWZudWxsZnJlZS5jb2NjaQo+Cj4g Q0M6IEthcm9sIEhlcmJzdCA8bm91dmVhdUBrYXJvbGhlcmJzdC5kZT4KPiBTaWduZWQtb2ZmLWJ5 OiBGZW5nZ3VhbmcgV3UgPGZlbmdndWFuZy53dUBpbnRlbC5jb20+ClNpZ25lZC1vZmYtYnk6IE1h cnRpbiBQZXJlcyA8bWFydGluLnBlcmVzQGZyZWUuZnI+Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965648AbcDMHzs (ORCPT ); Wed, 13 Apr 2016 03:55:48 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:34610 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932404AbcDMHzr (ORCPT ); Wed, 13 Apr 2016 03:55:47 -0400 Subject: Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings To: kbuild test robot , Karol Herbst References: <201604131531.CJokPLHc%fengguang.wu@intel.com> <20160413070742.GA9311@lkp-nex05> Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Ben Skeggs , David Airlie , dri-devel@lists.freedesktop.org From: Martin Peres Message-ID: <570DFB71.4070106@free.fr> Date: Wed, 13 Apr 2016 10:55:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160413070742.GA9311@lkp-nex05> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/04/16 10:07, kbuild test robot wrote: > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Karol Herbst > Signed-off-by: Fengguang Wu Signed-off-by: Martin Peres