From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 925A27317D for ; Wed, 13 Apr 2016 15:59:10 +0000 (UTC) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id u3DFxACh015504 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 13 Apr 2016 08:59:10 -0700 (PDT) Received: from server.local (147.11.119.99) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.3.248.2; Wed, 13 Apr 2016 08:59:09 -0700 To: Khem Raj References: <1458077979-23303-1-git-send-email-raj.khem@gmail.com> <56E91CC8.9060907@dest-unreach.org> <570D631F.5020503@windriver.com> From: Bruce Ashfield Message-ID: <570E6CCD.3090706@windriver.com> Date: Wed, 13 Apr 2016 11:59:09 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2016 15:59:11 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 2016-04-13 11:57 AM, Khem Raj wrote: > On Tue, Apr 12, 2016 at 3:33 PM, Khem Raj wrote: >> I think I see the problem now. The constant should be converted to use Bnn >> values. When calling the baudrate apis. I will send a patch for you to test >> once I am close to computer > > I have sent a potential patch. > > http://lists.openembedded.org/pipermail/openembedded-core/2016-April/120229.html > > It worked on musl env that I had ready here. Can you test it > with your env and make sure it works for you ? Will do. Launching builds now. I'll follow up once I know one way or another. Bruce > > > > >> >> On Apr 12, 2016 6:20 PM, "Khem Raj" wrote: >> >> Since you have it reproduced. Can you check which of the api call is >> failing? >> >> On Apr 12, 2016 5:05 PM, "Bruce Ashfield" >> wrote: >>> >>> On 2016-04-12 1:53 PM, Khem Raj wrote: >>>> >>>> FYI >>> >>> >>> Thanks. I can also confirm that when I dropped the patch, I'm >>> back up and running assertion free. >>> >>> Bruce >>> >>>> >>>> ---------- Forwarded message ---------- >>>> From: Gerhard Rieger >>>> Date: Wed, Mar 16, 2016 at 4:43 AM >>>> Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs >>>> To: Khem Raj >>>> >>>> >>>> Thank you, I will check this patch! >>>> - Gerhard >>>> >>>> >>>> Am 15.03.2016 um 22:39 schrieb Khem Raj: >>>>> >>>>> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed() >>>>> instead of operating on c_ispeed and c_ospeed termios structure >>>>> members directly because they are not guaranteed to exist on all >>>>> libc implementations >>>>> >>>>> Signed-off-by: Khem Raj >>>>> --- >>>>> xioinitialize.c | 8 ++++---- >>>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/xioinitialize.c b/xioinitialize.c >>>>> index 9f50155..632ca4c 100644 >>>>> --- a/xioinitialize.c >>>>> +++ b/xioinitialize.c >>>>> @@ -65,10 +65,10 @@ int xioinitialize(void) { >>>>> #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET != >>>>> -1) >>>>> #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1) >>>>> #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1) >>>>> - tdata.termarg.c_ispeed = 0x56789abc; >>>>> - tdata.termarg.c_ospeed = 0x6789abcd; >>>>> - assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]); >>>>> - assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]); >>>>> + cfsetispeed(&tdata.termarg, 0x56789abc); >>>>> + cfsetospeed(&tdata.termarg, 0x6789abcd); >>>>> + assert(cfgetispeed(&tdata.termarg) == >>>>> tdata.speeds[ISPEED_OFFSET]); >>>>> + assert(cfgetospeed(&tdata.termarg) == >>>>> tdata.speeds[OSPEED_OFFSET]); >>>>> #endif >>>>> #endif >>>>> #endif >>>>> >>> >>