All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] efi_loader: Add distro boot script for removable media
Date: Wed, 13 Apr 2016 11:54:25 -0600	[thread overview]
Message-ID: <570E87D1.7050603@wwwdotorg.org> (raw)

I've spotted a couple of problems in 74522c898b35 "efi_loader: Add 
distro boot script for removable media". These help explain something I 
found strange in the commit description of the recently sent patch 
"jetson-tk1: Set fdtfile environment variable"; "The 4.5.0 kernel cannot 
cope with U-Boot's internal device tree".

> 	"load_efi_dtb="                                                   \
> 		"load ${devtype} ${devnum}:${distro_bootpart} "           \
> 			"${fdt_addr_r} ${prefix}${fdtfile}; "             \
> 		"fdt addr ${fdt_addr_r}\0"                                \
> 	\

The "fdt addr" command shouldn't be there. That affects the DT that 
U-Boot's internal commands operate on internally. That is entirely 
unrelated to the the DT that is passed to the Linux kernel. Instead, the 
EFI code should pass the DTB at ${kernel_addr_r} to the kernel, just 
like all other boot mechanisms do.

If by some chance U-Boot is configured by DTB and that DTB is fully 
suitable to pass to the Linux kernel, then the board-specific code can 
arrange for ${kernel_addr_r} to point at that same DTB, thus removing 
the need to load one. However, that's unlikely to happen too often at 
present; the most complete DTBs are housed in the Linux kernel source 
tree, and DTB ABI still isn't really a thing, so in practice one mostly 
wants to load a DTB that was built as part of the kernel being booted, 
and hence U-Boot's DTB isn't relevant.

             reply	other threads:[~2016-04-13 17:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 17:54 Stephen Warren [this message]
2016-04-13 18:24 ` [U-Boot] efi_loader: Add distro boot script for removable media Alexander Graf
2016-04-13 18:31   ` Stephen Warren
2016-04-13 18:47     ` Alexander Graf
2016-04-13 18:54       ` Andreas Färber
2016-04-13 19:01         ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570E87D1.7050603@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.