From: "H. Peter Anvin" <hpa@zytor.com>
To: "Richard W.M. Jones" <rjones@redhat.com>, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org,
luto@kernel.org, viro@zeniv.linux.org.uk,
mathieu.desnoyers@efficios.com, zab@redhat.com,
emunson@akamai.com, paulmck@linux.vnet.ibm.com,
aarcange@redhat.com, josh@joshtriplett.org, xemul@parallels.com,
sfr@canb.auug.org.au, milosz@adfin.com, rostedt@goodmis.org,
arnd@arndb.de, ebiederm@xmission.com, gorcunov@openvz.org,
iulia.manda21@gmail.com, dave.hansen@linux.intel.com,
mguzik@redhat.com, adobriyan@gmail.com, dave@stgolabs.net,
linux-api@vger.kernel.org, gorcunov@gmail.com, fw@deneb.enyo.de,
walters@verbum.org
Subject: Re: [PATCH v4 0/3] vfs: Define new syscall umask2 [formerly getumask]
Date: Wed, 13 Apr 2016 12:37:42 -0700 [thread overview]
Message-ID: <570EA006.5010608@zytor.com> (raw)
In-Reply-To: <1460574336-18930-1-git-send-email-rjones@redhat.com>
On 04/13/16 12:05, Richard W.M. Jones wrote:
> v3 -> v4:
>
> - Rename the syscall: getumask becomes umask2.
>
> - Add flags parameter, with one flag (UMASK_GET_MASK).
>
> - Expand the rationale for this change in the first commit message.
>
>
> It's not possible to read the process umask without also modifying it,
> which is what umask(2) does. A library cannot read umask safely,
> especially if the main program might be multithreaded.
>
I wouldn't say "if"; that is the case when it matters.
I have to say I'm skeptic to the need for umask2() as opposed to
getumask(). I would also like to be able to get the umask of another
process, which would argue for adding it to /proc anyway.
-hpa
next prev parent reply other threads:[~2016-04-13 19:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 19:05 [PATCH v4 0/3] vfs: Define new syscall umask2 [formerly getumask] Richard W.M. Jones
2016-04-13 19:05 ` Richard W.M. Jones
2016-04-13 19:05 ` [PATCH v4 1/3] vfs: Define new syscall umask2 Richard W.M. Jones
2016-04-13 19:05 ` [PATCH v4 2/3] x86: Wire up new umask2 system call on x86 Richard W.M. Jones
[not found] ` <1460574336-18930-3-git-send-email-rjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-04-13 19:57 ` kbuild test robot
2016-04-13 19:57 ` kbuild test robot
2016-04-13 19:05 ` [PATCH v4 3/3] vfs: selftests: Add test for umask2 system call Richard W.M. Jones
2016-04-13 19:37 ` H. Peter Anvin [this message]
[not found] ` <570EA006.5010608-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2016-04-13 20:45 ` [PATCH v4 0/3] vfs: Define new syscall umask2 [formerly getumask] Florian Weimer
2016-04-13 20:45 ` Florian Weimer
[not found] ` <87shypck6m.fsf-ZqZwdwZz9NfTBotR3TxKnbNAH6kLmebB@public.gmane.org>
2016-04-13 20:53 ` Richard W.M. Jones
2016-04-13 20:53 ` Richard W.M. Jones
[not found] ` <1460574336-18930-1-git-send-email-rjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-04-13 19:29 ` umask2 man page (was: Re: [PATCH v4 0/3] vfs: Define new syscall umask2 [formerly getumask]) Richard W.M. Jones
2016-04-13 19:29 ` Richard W.M. Jones
2016-04-13 23:09 ` [PATCH v4 0/3] vfs: Define new syscall umask2 [formerly getumask] Stephen Rothwell
2016-04-13 23:09 ` Stephen Rothwell
2016-04-14 9:15 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570EA006.5010608@zytor.com \
--to=hpa@zytor.com \
--cc=aarcange@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=ebiederm@xmission.com \
--cc=emunson@akamai.com \
--cc=fw@deneb.enyo.de \
--cc=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=iulia.manda21@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mguzik@redhat.com \
--cc=milosz@adfin.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rjones@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=walters@verbum.org \
--cc=xemul@parallels.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.