From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: clean up common config options
Date: Thu, 14 Apr 2016 00:03:23 +0200 [thread overview]
Message-ID: <570EC22B.5020205@denx.de> (raw)
In-Reply-To: <570E825A.2080806@denx.de>
On 04/13/2016 07:31 PM, Stefan Roese wrote:
> On 13.04.2016 17:34, dinguyen at opensource.altera.com wrote:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Move common config options like these to socfpga_common.h:
>>
>> CONFIG_SYS_NO_FLASH
>> CONFIG_DOS_PARTITION
>> CONFIG_FAT_WRITE
>> CONFIG_HW_WATCHDOG
>>
>> CONFIG_CMD_ASKENV
>> CONFIG_CMD_BOOTZ
>> CONFIG_CMD_CACHE
>> CONFIG_CMD_DHCP
>> CONFIG_CMD_EXT4
>> CONFIG_CMD_EXT4_WRITE
>> CONFIG_CMD_FAT
>> CONFIG_CMD_FS_GENERIC
>> CONFIG_CMD_GREPENV
>> CONFIG_CMD_MEMTEST
>> CONFIG_CMD_MII
>> CONFIG_CMD_MMC
>> CONFIG_CMD_PING
>> CONFIG_CMD_SF
>> CONFIG_CMD_SPI
>> CONFIG_CMD_TIME
>>
>> to avoid defining them in individual SoCFPGA config files.
>>
>> Also to avoid a build error, move CONFIG_CMD_GPIO that was in
>> socfpga_sr1500.h to socfpga_sr1500_defconfig.
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Acked-by: Stefan Roese <sr@denx.de>
The reason why these configs were not in socfpga_common.h was to let
boards configure which commands they will include, but I am fine with
this patch too.
Would you be interested in sending replacement patch , which moves these
configs to Kconfig instead and move the config options to
configs/socfpga*defconfig ? It would be helpful, but if not, I will
just pick this one.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-04-13 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 15:34 [U-Boot] [PATCH] arm: socfpga: clean up common config options dinguyen at opensource.altera.com
2016-04-13 17:31 ` Stefan Roese
2016-04-13 22:03 ` Marek Vasut [this message]
2016-04-14 20:31 ` Dinh Nguyen
2016-04-13 22:05 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570EC22B.5020205@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.