Re: [Qemu-devel] [PATCH for-2.7 v2 1/3] vl: Use exit(1) when requested VGA interface is unavailable

[Marcel Apfelbaum <marcel@redhat.com>]

On 04/14/2016 03:51 AM, Eduardo Habkost wrote:
> Instead of using exit(0), use exit(1) when an unavailable VGA
> interface is used in the command-line to indicate it's an error.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   vl.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 9df534f..3c565bb 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2025,28 +2025,28 @@ static void select_vgahw (const char *p)
>               vga_interface_type = VGA_STD;
>           } else {
>               error_report("standard VGA not available");
> -            exit(0);
> +            exit(1);
>           }
>       } else if (strstart(p, "cirrus", &opts)) {
>           if (cirrus_vga_available()) {
>               vga_interface_type = VGA_CIRRUS;
>           } else {
>               error_report("Cirrus VGA not available");
> -            exit(0);
> +            exit(1);
>           }
>       } else if (strstart(p, "vmware", &opts)) {
>           if (vmware_vga_available()) {
>               vga_interface_type = VGA_VMWARE;
>           } else {
>               error_report("VMWare SVGA not available");
> -            exit(0);
> +            exit(1);
>           }
>       } else if (strstart(p, "virtio", &opts)) {
>           if (virtio_vga_available()) {
>               vga_interface_type = VGA_VIRTIO;
>           } else {
>               error_report("Virtio VGA not available");
> -            exit(0);
> +            exit(1);
>           }
>       } else if (strstart(p, "xenfb", &opts)) {
>           vga_interface_type = VGA_XENFB;
> @@ -2055,21 +2055,21 @@ static void select_vgahw (const char *p)
>               vga_interface_type = VGA_QXL;
>           } else {
>               error_report("QXL VGA not available");
> -            exit(0);
> +            exit(1);
>           }
>       } else if (strstart(p, "tcx", &opts)) {
>           if (tcx_vga_available()) {
>               vga_interface_type = VGA_TCX;
>           } else {
>               error_report("TCX framebuffer not available");
> -            exit(0);
> +            exit(1);
>           }
>       } else if (strstart(p, "cg3", &opts)) {
>           if (cg3_vga_available()) {
>               vga_interface_type = VGA_CG3;
>           } else {
>               error_report("CG3 framebuffer not available");
> -            exit(0);
> +            exit(1);
>           }
>       } else if (!strstart(p, "none", &opts)) {
>       invalid_vga:
>

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel