From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [PATCH RFC 07/15] pci: Add pci_probe() and pci_shutdown() Date: Thu, 14 Apr 2016 09:45:57 +0200 Message-ID: <570F4AB5.9020300@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Andrew Jones To: Alexander Gordeev , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35897 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752453AbcDNHqB (ORCPT ); Thu, 14 Apr 2016 03:46:01 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BBA9480085 for ; Thu, 14 Apr 2016 07:46:00 +0000 (UTC) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 11.04.2016 13:04, Alexander Gordeev wrote: > Cc: Thomas Huth > Cc: Andrew Jones > Signed-off-by: Alexander Gordeev > --- > lib/asm-generic/pci.h | 15 ++++++++++++++- > lib/pci.c | 1 - > lib/pci.h | 2 ++ > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/lib/asm-generic/pci.h b/lib/asm-generic/pci.h > index 3fa0b2ab1fe6..175b0497ed82 100644 > --- a/lib/asm-generic/pci.h > +++ b/lib/asm-generic/pci.h > @@ -1,4 +1,17 @@ > #ifndef _ASM_GENERIC_PCI_H_ > #define _ASM_GENERIC_PCI_H_ > -#error need architecture specific asm/pci.h > + > +#ifndef pci_probe > +static inline bool pci_probe(void) > +{ > + return true; > +} > +#endif > + > +#ifndef pci_shutdown > +static inline void pci_shutdown(void) > +{ > +} > +#endif > + > #endif What are these functions supposed to do exactly? (and why is the default implementation empty?) ... some comments would be really helpful here. Thomas