All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Peter Rosin <peda@lysator.liu.se>
Cc: linux-clk@vger.kernel.org
Subject: Re: Programming a clock in the device tree
Date: Thu, 14 Apr 2016 13:32:04 +0200	[thread overview]
Message-ID: <570F7FB4.9010504@samsung.com> (raw)
In-Reply-To: <570ED310.3020604@lysator.liu.se>

On 04/14/2016 01:15 AM, Peter Rosin wrote:
> Hi!
> 
> I'm trying to connect (in a device tree) a programmable clock
> to a device that does not expect the clock to need any
> programming.
> 
> I can hack this and add a clk_set_rate at the appropriate point
> in the driver for the clk consumer, but I was expecting to see
> some way of just adding a device tree node to get this done for
> me.
> 
> It just feels wrong to add this hack to the driver as the
> programmable clock might be needed for more than one device and
> the decisions by one driver might conflict with other needs (the
> driver in question can use a variety of clock rates, so the rate
> it should request is policy not belonging in a driver).
> 
> Adding a device tree frequency property to the driver in question
> is also a possibility, but that would need code duplication for
> other clock consumers as well, when someone wants to use those
> drivers in the way I'm now trying to use this driver.
> 
> I.e. I expected to see a driver, just like the fixed clock
> driver, but that programs a parent clock instead of just
> representing a fixed oscillator. Is there such a thing? If not,
> what is it that I'm not seeing? Because I just can't believe that
> I'm the first person to need this...

How about using assigned-{clocks, clock-parents, clock-rates}
properties in the clock provider node? Wouldn't it help in your
case? Documentation can be found in Documentation/devicetree/
bindings/clock/clock-bindings.txt


-- 
Regards,
Sylwester

  reply	other threads:[~2016-04-14 11:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 23:15 Programming a clock in the device tree Peter Rosin
2016-04-14 11:32 ` Sylwester Nawrocki [this message]
2016-04-14 20:44   ` Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570F7FB4.9010504@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=peda@lysator.liu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.