From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 4804B7CA1 for ; Thu, 14 Apr 2016 09:11:08 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 0AAEE8F8318 for ; Thu, 14 Apr 2016 07:11:07 -0700 (PDT) Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) by cuda.sgi.com with ESMTP id dDicQUY1ryJj7fpo (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Thu, 14 Apr 2016 07:11:06 -0700 (PDT) Received: by mail-ig0-f179.google.com with SMTP id ui10so91854846igc.1 for ; Thu, 14 Apr 2016 07:11:06 -0700 (PDT) Subject: Re: [PATCH v4 0/8] block: prepare for multipage bvecs References: <1460634438-26530-1-git-send-email-ming.lei@canonical.com> From: Jens Axboe Message-ID: <570FA4F7.6020301@kernel.dk> Date: Thu, 14 Apr 2016 08:11:03 -0600 MIME-Version: 1.0 In-Reply-To: <1460634438-26530-1-git-send-email-ming.lei@canonical.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ming Lei , Jens Axboe , linux-kernel@vger.kernel.org Cc: Christoph Hellwig , Jan Kara , Mike Snitzer , "open list:XFS FILESYSTEM" , linux-block@vger.kernel.org, Al Viro , Shaohua Li , Tejun Heo , Keith Busch , Kent Overstreet , "Kirill A. Shutemov" , "open list:DRBD DRIVER" On 04/14/2016 05:46 AM, Ming Lei wrote: > Hi, > > Interests[1] have been shown in multipage bvecs, so this patchset > try to prepare for the support and do two things: > > 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), > then we can drop the non-standard way for iterating bvec, which > can be thought as a good cleanup for lib/iov_iter.c > > 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only > one user for each. Once multipage bvecs is introduced, one bio > may hold lots of sectors, and we should always use sort of BIO_MAX_VECS > which should be introduced in future and is similiar with current > BIO_MAX_PAGES. > > xfstests(-a auto) have been run over ext4/xfs and no regression found > by this patchset. We've had too many disasters in the block layer the last few series, I'm making the 4.7 round a nice and small one. I don't mind taking prep patches for the multipage bvecs, if they are simple and clean, but that's about the extent of it. Just a heads up. -- Jens Axboe _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f169.google.com (mail-ig0-f169.google.com [209.85.213.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id 481831056446 for ; Thu, 14 Apr 2016 16:16:59 +0200 (CEST) Received: by mail-ig0-f169.google.com with SMTP id f1so148942733igr.1 for ; Thu, 14 Apr 2016 07:16:59 -0700 (PDT) To: Ming Lei , Jens Axboe , linux-kernel@vger.kernel.org References: <1460634438-26530-1-git-send-email-ming.lei@canonical.com> From: Jens Axboe Message-ID: <570FA4F7.6020301@kernel.dk> Date: Thu, 14 Apr 2016 08:11:03 -0600 MIME-Version: 1.0 In-Reply-To: <1460634438-26530-1-git-send-email-ming.lei@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , Jan Kara , Mike Snitzer , "open list:XFS FILESYSTEM" , linux-block@vger.kernel.org, Al Viro , Shaohua Li , Tejun Heo , Keith Busch , Kent Overstreet , "Kirill A. Shutemov" , "open list:DRBD DRIVER" Subject: Re: [Drbd-dev] [PATCH v4 0/8] block: prepare for multipage bvecs List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 04/14/2016 05:46 AM, Ming Lei wrote: > Hi, > > Interests[1] have been shown in multipage bvecs, so this patchset > try to prepare for the support and do two things: > > 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), > then we can drop the non-standard way for iterating bvec, which > can be thought as a good cleanup for lib/iov_iter.c > > 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only > one user for each. Once multipage bvecs is introduced, one bio > may hold lots of sectors, and we should always use sort of BIO_MAX_VECS > which should be introduced in future and is similiar with current > BIO_MAX_PAGES. > > xfstests(-a auto) have been run over ext4/xfs and no regression found > by this patchset. We've had too many disasters in the block layer the last few series, I'm making the 4.7 round a nice and small one. I don't mind taking prep patches for the multipage bvecs, if they are simple and clean, but that's about the extent of it. Just a heads up. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755791AbcDNOLK (ORCPT ); Thu, 14 Apr 2016 10:11:10 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:35914 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755246AbcDNOLI (ORCPT ); Thu, 14 Apr 2016 10:11:08 -0400 Subject: Re: [PATCH v4 0/8] block: prepare for multipage bvecs To: Ming Lei , Jens Axboe , linux-kernel@vger.kernel.org References: <1460634438-26530-1-git-send-email-ming.lei@canonical.com> Cc: linux-block@vger.kernel.org, Christoph Hellwig , Al Viro , "open list:DRBD DRIVER" , Jan Kara , Keith Busch , Kent Overstreet , "Kirill A. Shutemov" , Mike Snitzer , Shaohua Li , Tejun Heo , "open list:XFS FILESYSTEM" From: Jens Axboe Message-ID: <570FA4F7.6020301@kernel.dk> Date: Thu, 14 Apr 2016 08:11:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460634438-26530-1-git-send-email-ming.lei@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2016 05:46 AM, Ming Lei wrote: > Hi, > > Interests[1] have been shown in multipage bvecs, so this patchset > try to prepare for the support and do two things: > > 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), > then we can drop the non-standard way for iterating bvec, which > can be thought as a good cleanup for lib/iov_iter.c > > 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only > one user for each. Once multipage bvecs is introduced, one bio > may hold lots of sectors, and we should always use sort of BIO_MAX_VECS > which should be introduced in future and is similiar with current > BIO_MAX_PAGES. > > xfstests(-a auto) have been run over ext4/xfs and no regression found > by this patchset. We've had too many disasters in the block layer the last few series, I'm making the 4.7 round a nice and small one. I don't mind taking prep patches for the multipage bvecs, if they are simple and clean, but that's about the extent of it. Just a heads up. -- Jens Axboe