From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
"Shuai Ruan" <shuai.ruan@linux.intel.com>
Cc: kvm@vger.kernel.org, allen.m.kay@intel.com
Subject: Re: [PATCH] KVM: x86: Add three MSRs to the list of ignored MSRs
Date: Thu, 14 Apr 2016 16:42:55 +0200 [thread overview]
Message-ID: <570FAC6F.10704@redhat.com> (raw)
In-Reply-To: <20160414133332.GA3350@potion.brq.redhat.com>
On 14/04/2016 15:33, Radim Krčmář wrote:
> The main bug in KVM is that it allows the guest to think that it runs on
> CPU that isn't emulated: any CPU that has MSR_PLATFORM_INFO shouldn't
> be exposed in KVM.
That's all of them. f/m/s values and the model name are a useful
debugging tool. Considering that MSR_PLATFORM_INFO is hardly ever used,
it doesn't seem to be a great compromise.
The actual question is why the hell a graphics driver cares about it.
Paolo
> Incorrect use of CPU also is a userspace problem, so
> KVM could just pass this MSR for emulation to userspace.
> (Passing to userspace won't directly fix your problem, though)
next prev parent reply other threads:[~2016-04-14 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 9:28 [PATCH] KVM: x86: Add three MSRs to the list of ignored MSRs Shuai Ruan
2016-04-14 13:33 ` Radim Krčmář
2016-04-14 14:42 ` Paolo Bonzini [this message]
2016-04-14 16:29 ` Radim Krčmář
2016-04-15 10:48 ` Paolo Bonzini
2016-04-15 14:12 ` Radim Krčmář
[not found] ` <20160419092025.GA2651@shuai.ruan@linux.intel.com>
2016-04-19 16:10 ` Kay, Allen M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570FAC6F.10704@redhat.com \
--to=pbonzini@redhat.com \
--cc=allen.m.kay@intel.com \
--cc=kvm@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=shuai.ruan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.