From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:34895 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755690AbcDNPl2 (ORCPT ); Thu, 14 Apr 2016 11:41:28 -0400 Subject: Re: [PATCH 2/3] writeback: add wbc_to_write() To: Jan Kara References: <1460486633-26099-1-git-send-email-axboe@fb.com> <1460486633-26099-3-git-send-email-axboe@fb.com> <20160413095032.GH15098@quack2.suse.cz> CC: , From: Jens Axboe Message-ID: <570FBA22.7030302@fb.com> Date: Thu, 14 Apr 2016 09:41:22 -0600 MIME-Version: 1.0 In-Reply-To: <20160413095032.GH15098@quack2.suse.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 04/13/2016 03:50 AM, Jan Kara wrote: > On Tue 12-04-16 12:43:52, Jens Axboe wrote: >> Add wbc_to_write(), which returns the write type to use, based on a >> struct writeback_control. No functional changes in this patch, but it >> prepares us for factoring other wbc fields for write type. >> >> No intended functional changes in this patch. > > I like the patch except for the function name ;). Maybe wbc_to_write_cmd() > or something like that? Yep, I like that, I've made that change. Thanks! -- Jens Axboe