Re: [oe] [meta-oe][PATCH] testdisk: add recipe

[Gyorgy Sarvari <skandigraun@gmail.com>]

It looks like this recipe was created with/for an old version of Yocto.
Could you please prepare it for master branch?
I have added some comments inline.

On 4/27/25 17:27, Wen Yang via lists.openembedded.org wrote:
> testdisk is a free data recovery software primarily designed to help
> recover lost partitions and/or make non-booting disks bootable again
> when these symptoms are caused by faulty software.
>
> Signed-off-by: Wen Yang <wen.yang@linux.dev>
> ---
>  .../recipes-support/testdisk/testdisk_7.2.bb  | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta-oe/recipes-support/testdisk/testdisk_7.2.bb
>
> diff --git a/meta-oe/recipes-support/testdisk/testdisk_7.2.bb b/meta-oe/recipes-support/testdisk/testdisk_7.2.bb
> new file mode 100644
> index 0000000000..64e3d612c1
> --- /dev/null
> +++ b/meta-oe/recipes-support/testdisk/testdisk_7.2.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "TestDisk is a free data recovery software primarily designed to help recover lost partitions and/or make non-booting disks bootable again when these symptoms are caused by faulty software, certain types of viruses or human error (such as accidentally deleting your Partition Table)."
> +LICENSE = "GPLv2"
This LICENSE value is deprecated. Please use spdx identifiers if
possible/applicable, like GPL-2.0-only or GPL-2.0-or-later
> +LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
> +PR = "r1"
Is PR needed in this recipe?
> +
> +DEPENDS = "jpeg ncurses e2fsprogs"
> +
> +SRC_URI = "https://github.com/cgsecurity/testdisk/archive/refs/tags/v7.2.tar.gz"
Archived tags in Github are unfortunately not immutable, so their use is
discouraged (and it also throws a fatal QA check). It is preferred to
use the direct commit ID.
> +S = "${WORKDIR}/testdisk-7.2"
> +
> +inherit autotools pkgconfig
> +
> +PACKAGES =+ "photorec"
It is recommended to prepend the extra packages' names with the main
recipe name, like ${PN}-photorec
> +
> +DESCRIPTION_photorec = "Photorec is file data recovery software designed to recover lost files including video, documents and archives from Hard Disks and CDRom and lost pictures (Photo Recovery) from digital camera memory."
> +FILES_photorec = "${sbindir}/photorec"
The underscore override syntax has changed to ":".
> +
> +SRC_URI[md5sum] = "c47d69e2c950b6b2f0dadb2a2921d6c6"
> +SRC_URI[sha256sum] = "f3fe7ec02cafcbe792a4c783976de3a6312963b0ce8a613d38adbcd8bdca0517"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#117176): https://lists.openembedded.org/g/openembedded-devel/message/117176
> Mute This Topic: https://lists.openembedded.org/mt/112489401/6084445
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>