From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [RFC] U-Boot: don't check hashes for U-Boot external patches
Date: Thu, 14 Apr 2016 23:25:15 +0200 [thread overview]
Message-ID: <57100ABB.8090206@mind.be> (raw)
In-Reply-To: <57100509.8040804@mind.be>
On 04/14/16 23:00, Arnout Vandecappelle wrote:
> On 04/14/16 16:32, julien.boibessot at free.fr wrote:
>> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
>>
>> BR2_TARGET_UBOOT_PATCH allows user to give URL of patches on the Web, but in
>> that case BR dl infra tries to compare hashes of the downloaded patches with the
>> infos from boot/uboot/uboot.hash.
>> So, for that case (user specified patches), tell BR not to check hashes.
>>
>> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
>> ---
>> boot/uboot/uboot.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
>> index 48f40c3..9e24b48 100644
>> --- a/boot/uboot/uboot.mk
>> +++ b/boot/uboot/uboot.mk
>> @@ -109,6 +109,8 @@ UBOOT_POST_RSYNC_HOOKS += UBOOT_COPY_OLD_LICENSE_FILE
>> # directories or files.
>> UBOOT_PATCHES = $(call qstrip,$(BR2_TARGET_UBOOT_PATCH))
>> UBOOT_PATCH = $(filter ftp://% http://% https://%,$(UBOOT_PATCHES))
>> +UBOOT_PATCHES_NAME = $(notdir $(UBOOT_PATCHES))
>
> Since only the non-local patches will be downloaded, perhaps it's better to
> use UBOOT_PATCH instead of UBOOT_PATCHES.
>
> Also, there is no need to use an additional variable for this, it's used only
> once.
Oh, and something similar should be done for LINUX_PATCH as well.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-04-14 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 14:32 [Buildroot] [PATCH] [RFC] U-Boot: don't check hashes for U-Boot external patches julien.boibessot at free.fr
2016-04-14 21:00 ` Arnout Vandecappelle
2016-04-14 21:25 ` Arnout Vandecappelle [this message]
2016-04-18 10:28 ` Julien Boibessot
2016-04-18 23:18 ` Arnout Vandecappelle
2016-04-20 8:47 ` Julien Boibessot
2016-04-20 20:18 ` Arnout Vandecappelle
2016-04-24 16:11 ` Yann E. MORIN
2016-06-12 21:36 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57100ABB.8090206@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.