From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH 01/14] drm/amdgpu: use drm_crtc_send_vblank_event() Date: Fri, 15 Apr 2016 11:55:16 +0900 Message-ID: <57105814.20502@daenzer.net> References: <1460656118-16766-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 20CE66EB76 for ; Fri, 15 Apr 2016 02:55:21 +0000 (UTC) In-Reply-To: <1460656118-16766-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: Tom St Denis , Jammy Zhou , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , open list , dri-devel@lists.freedesktop.org, yanyang1 , Alex Deucher , Gustavo Padovan , =?UTF-8?Q?Christian_K=c3=b6nig?= List-Id: dri-devel@lists.freedesktop.org T24gMTUuMDQuMjAxNiAwMjo0OCwgR3VzdGF2byBQYWRvdmFuIHdyb3RlOgo+IEZyb206IEd1c3Rh dm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPiAKPiBSZXBsYWNl IHRoZSBsZWdhY3kgZHJtX3NlbmRfdmJsYW5rX2V2ZW50KCkgd2l0aCB0aGUgbmV3IGhlbHBlciBm dW5jdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFk b3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2RjZV92MTBfMC5jIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjEx XzAuYyB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3Y4XzAuYyAgfCAy ICstCj4gIDMgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjEwXzAuYyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92MTBfMC5jCj4gaW5kZXggNmRlMmNlNTMu LjkyYzVhNzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3Yx MF8wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjEwXzAuYwo+IEBA IC0zMzcwLDcgKzMzNzAsNyBAQCBzdGF0aWMgaW50IGRjZV92MTBfMF9wYWdlZmxpcF9pcnEoc3Ry dWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAo+ICAJLyogd2FrZXVwIHVzZXJzYXBjZSAqLwo+ ICAJaWYgKHdvcmtzLT5ldmVudCkKPiAtCQlkcm1fc2VuZF92YmxhbmtfZXZlbnQoYWRldi0+ZGRl diwgY3J0Y19pZCwgd29ya3MtPmV2ZW50KTsKPiArCQlkcm1fY3J0Y19zZW5kX3ZibGFua19ldmVu dCgmYW1kZ3B1X2NydGMtPmJhc2UsIHdvcmtzLT5ldmVudCk7Cj4gIAo+ICAJc3Bpbl91bmxvY2tf aXJxcmVzdG9yZSgmYWRldi0+ZGRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+ICAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMV8wLmMgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9kY2VfdjExXzAuYwo+IGluZGV4IGU5Y2NjNmIuLjJmNzg0ZjIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMV8wLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjExXzAuYwo+IEBAIC0zMzY2LDcgKzMz NjYsNyBAQCBzdGF0aWMgaW50IGRjZV92MTFfMF9wYWdlZmxpcF9pcnEoc3RydWN0IGFtZGdwdV9k ZXZpY2UgKmFkZXYsCj4gIAo+ICAJLyogd2FrZXVwIHVzZXJzYXBjZSAqLwo+ICAJaWYod29ya3Mt PmV2ZW50KQo+IC0JCWRybV9zZW5kX3ZibGFua19ldmVudChhZGV2LT5kZGV2LCBjcnRjX2lkLCB3 b3Jrcy0+ZXZlbnQpOwo+ICsJCWRybV9jcnRjX3NlbmRfdmJsYW5rX2V2ZW50KCZhbWRncHVfY3J0 Yy0+YmFzZSwgd29ya3MtPmV2ZW50KTsKPiAgCj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZh ZGV2LT5kZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjhfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvZGNlX3Y4XzAuYwo+IGluZGV4IGU1NmI1NWQuLjkxNTVlM2IgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3Y4XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2RjZV92OF8wLmMKPiBAQCAtMzM3OSw3ICszMzc5LDcgQEAgc3RhdGljIGlu dCBkY2VfdjhfMF9wYWdlZmxpcF9pcnEoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAo+ ICAJLyogd2FrZXVwIHVzZXJzYXBjZSAqLwo+ICAJaWYgKHdvcmtzLT5ldmVudCkKPiAtCQlkcm1f c2VuZF92YmxhbmtfZXZlbnQoYWRldi0+ZGRldiwgY3J0Y19pZCwgd29ya3MtPmV2ZW50KTsKPiAr CQlkcm1fY3J0Y19zZW5kX3ZibGFua19ldmVudCgmYW1kZ3B1X2NydGMtPmJhc2UsIHdvcmtzLT5l dmVudCk7Cj4gIAo+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmYWRldi0+ZGRldi0+ZXZlbnRf bG9jaywgZmxhZ3MpOwo+ICAKPiAKClRoaXMgcGF0Y2ggYW5kIHBhdGNoIDggYXJlCgpSZXZpZXdl ZC1ieTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5kYWVuemVyQGFtZC5jb20+CgoKLS0gCkVhcnRo bGluZyBNaWNoZWwgRMOkbnplciAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICBodHRwOi8v d3d3LmFtZC5jb20KTGlicmUgc29mdHdhcmUgZW50aHVzaWFzdCAgICAgICAgICAgICB8ICAgICAg ICAgICAgIE1lc2EgYW5kIFggZGV2ZWxvcGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbcDOCzn (ORCPT ); Thu, 14 Apr 2016 22:55:43 -0400 Received: from darkcity.gna.ch ([195.226.6.51]:34176 "EHLO mail.gna.ch" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752117AbcDOCzm (ORCPT ); Thu, 14 Apr 2016 22:55:42 -0400 Subject: Re: [PATCH 01/14] drm/amdgpu: use drm_crtc_send_vblank_event() To: Gustavo Padovan References: <1460656118-16766-1-git-send-email-gustavo@padovan.org> Cc: dri-devel@lists.freedesktop.org, Tom St Denis , Jammy Zhou , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , open list , yanyang1 , Alex Deucher , Gustavo Padovan , =?UTF-8?Q?Christian_K=c3=b6nig?= From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Message-ID: <57105814.20502@daenzer.net> Date: Fri, 15 Apr 2016 11:55:16 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <1460656118-16766-1-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.04.2016 02:48, Gustavo Padovan wrote: > From: Gustavo Padovan > > Replace the legacy drm_send_vblank_event() with the new helper function. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c > index 6de2ce53..92c5a71 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c > @@ -3370,7 +3370,7 @@ static int dce_v10_0_pageflip_irq(struct amdgpu_device *adev, > > /* wakeup usersapce */ > if (works->event) > - drm_send_vblank_event(adev->ddev, crtc_id, works->event); > + drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event); > > spin_unlock_irqrestore(&adev->ddev->event_lock, flags); > > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c > index e9ccc6b..2f784f2 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c > @@ -3366,7 +3366,7 @@ static int dce_v11_0_pageflip_irq(struct amdgpu_device *adev, > > /* wakeup usersapce */ > if(works->event) > - drm_send_vblank_event(adev->ddev, crtc_id, works->event); > + drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event); > > spin_unlock_irqrestore(&adev->ddev->event_lock, flags); > > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > index e56b55d..9155e3b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > @@ -3379,7 +3379,7 @@ static int dce_v8_0_pageflip_irq(struct amdgpu_device *adev, > > /* wakeup usersapce */ > if (works->event) > - drm_send_vblank_event(adev->ddev, crtc_id, works->event); > + drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event); > > spin_unlock_irqrestore(&adev->ddev->event_lock, flags); > > This patch and patch 8 are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer