From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: tammo-v8BkjJTOJzf1qYPpFx2fzhvVK+yQ3ZXh@public.gmane.org,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [dracut] rd.shell won't work if "root=" is missing
Date: Fri, 15 Apr 2016 12:04:23 +0200 [thread overview]
Message-ID: <5710BCA7.30204@redhat.com> (raw)
In-Reply-To: <trinity-fb369bfb-8623-46c4-8628-71f8a6be4d9a-1451985097774@3capp-webde-bs44>
On 05.01.2016 10:11, tammo-v8BkjJTOJzf1qYPpFx2fzhvVK+yQ3ZXh@public.gmane.org wrote:
> Hi,
>
> i just stumbled upon a detail in dracut that i found surprising and appears as a small bug to me.
>
> If you boot a dracut image without giving a "root=" parameter (or e.g. a misspelled argument to that parameter) the system will _not_ drop you into a shell, even if rd.shell is set. IMHO this is not the expected behavior, as the manual says that rd.shell will drop you into a shell if rd.shell is set and no root is found. So i would suggest to change the "die()" function in the dracut-lib.sh and add a test for rd.shell in line 460 (getargbool 0 "rd.debug=" && emergency_shell) too. The system will already drop you in a shell if you have a "rd.debug" parameter set, but i think that rd.shell (and probably "rdshell" too) alone should be sufficient, as this is more convinient and less surprising.
>
> I could prepare a patch, if you prefer that.
>
> If this is not some kind of bug, you may call it a "wishlist item" and/or change the documentation accordingly.
>
> kr
> Tammo
>
yes... changed with
https://github.com/dracutdevs/dracut/commit/9d74747f926d038f2e149d70a9c8f955861ab354
prev parent reply other threads:[~2016-04-15 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 9:11 [dracut] rd.shell won't work if "root=" is missing tammo-v8BkjJTOJzf1qYPpFx2fzhvVK+yQ3ZXh
2016-04-15 10:04 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5710BCA7.30204@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tammo-v8BkjJTOJzf1qYPpFx2fzhvVK+yQ3ZXh@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.